Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to rails-template? #827

Closed
croaky opened this issue Feb 23, 2017 · 12 comments
Closed

Rename to rails-template? #827

croaky opened this issue Feb 23, 2017 · 12 comments

Comments

@croaky
Copy link
Contributor

croaky commented Feb 23, 2017

We have these other templates for languages and frameworks:

Opened thoughtbot/go-template#10 to rename Laces to Go template.

@croaky
Copy link
Contributor Author

croaky commented Feb 23, 2017

Fun fact: this was the original name of this repo back pre-GitHub 2007-ish when it was in a thoughtbot Subversion repo.

@tute
Copy link
Contributor

tute commented Feb 23, 2017

Note that a Rails Template is a preexisting concept in Rails: http://guides.rubyonrails.org/rails_application_templates.html

@jessieay
Copy link
Contributor

I like the name suspenders! I feel like template makes sense, but I think suspenders is more fun 👖

@mike-burns
Copy link
Contributor

Our hope (my hope? someone's hope) is to move suspenders away from being a command-line tool and toward being a set of rake tasks. Does the idea of suspenders-as-a-template remain consistent with the suspenders-as-rake-tasks perspective?

@toobulkeh
Copy link
Contributor

From a high-level architecture view, suspenders is a template with defaults. Running them as rake tasks after the defaults have already been setup from rails new is... misleading at best?

I don't think launching it from a rake task makes any more sense. The only advantage I immediately see is being able to know which version of suspenders (defaults) the project started with. But that's best held by a date/time in git -- not an artifact in a codebase -- unless "upgrading" is supportable in suspenders, which is more of a process for an Engine, not a template.

@croaky
Copy link
Contributor Author

croaky commented Aug 24, 2017

Suspenders has staying power.

@croaky croaky closed this as completed Aug 24, 2017
@toobulkeh
Copy link
Contributor

@mike-burns not sure if this is the right forum for this -- but one thing we've been discussing is how nice it would be to keep all of our projects up to date with core suspenders changes.

Is there such a thing as a framework-wrapper that could be versioned? Would this just be a CLI gem? Could Rails be extended as another framework?

@mike-burns
Copy link
Contributor

@toobulkeh for more history here, see #511, #765, #766, #767, and #855.

@toobulkeh
Copy link
Contributor

TL;DR: No - Suspenders is a generator only. OK.

@nickcharlton
Copy link
Member

but one thing we've been discussing is how nice it would be to keep all of our projects up to date with core suspenders changes.

We've spoken a bit about this in London, too (and I presume it's come up elsewhere outside of the issues/PRs @mike-burns linked to). I don't know too much about it, but there is an experiment kicking about looking at doing exactly what you'd quoted. As far as I understand it, it's not the easiest thing to figure out but we're looking into it.

@mike-burns
Copy link
Contributor

mike-burns commented Sep 6, 2017

There was also the trout era, as can be seen in fbf39d8, 3c11591, 1b4514d, a92abc8, 7b9bffc, and removed in #50.

@toobulkeh
Copy link
Contributor

I knew I wasn't the only one -- thanks for the references, good learnings. @nickcharlton I'd love to see the fruit of those labors -- or help with the laboring if you need a pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants