-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rails versions on Travis #367
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f1c6dbd
Update rails versions on Travis
composerinteralia 5601b68
Try with updated version of cucumber and reverted rails 6
alextrueman 9d15b94
revert rails version in gemfile
alextrueman 04b8241
add gems updates
alextrueman fa9e787
Attempt to get more logging
composerinteralia ed9a493
Temporarily run only 6.0
composerinteralia 24ec820
Explore other ways to generate app
composerinteralia c6e6973
Try to log full result of rails command
composerinteralia b072c83
Avoid installing JS
composerinteralia 1f50858
Remove extra logging
composerinteralia c4ca4c8
Run against all versions again
composerinteralia fa8e74f
Simplify Rails helper a bit
composerinteralia 60f9b79
Specific full requirements for all versions
composerinteralia 8589148
Attempt to get tests passing with less code
composerinteralia 2038d64
Remove unneeded test-unit step
composerinteralia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,47 +1,61 @@ | ||
# These are the versions of Rails we want to test against. | ||
appraise "rails4.2" do | ||
gem "rails", "~> 4.2.11" | ||
gem "sqlite3", "~> 1.3.6" | ||
end | ||
|
||
appraise "rails5.0" do | ||
gem "activerecord", "~> 5.0.7" | ||
gem "railties", "~> 5.0.7" | ||
gem "sqlite3", "~> 1.3.6" | ||
gem "actionmailer", "~> 5.0.7" | ||
gem "sass-rails" | ||
gem "byebug" | ||
gem "jbuilder", "~> 2.5" | ||
gem "listen", "~> 3.0.5" | ||
gem "puma", "~> 3.0" | ||
gem "rails", "~> 5.0.7", ">= 5.0.7.2" | ||
gem "sass-rails", "~> 5.0" | ||
gem "spring" | ||
gem "spring-watcher-listen", "~> 2.0.0" | ||
gem "uglifier", ">= 1.3.0" | ||
gem "web-console", ">= 3.3.0", group: :development | ||
end | ||
|
||
appraise "rails5.1" do | ||
gem "activerecord", "~> 5.1.7" | ||
gem "railties", "~> 5.1.7" | ||
gem "actionmailer", "~> 5.1.7" | ||
gem "sass-rails" | ||
gem "byebug" | ||
gem "capybara", ">= 2.15" | ||
gem "jbuilder", "~> 2.5" | ||
gem "listen", ">= 3.0.5", "< 3.2" | ||
gem "puma", "~> 3.7" | ||
gem "rails", "~> 5.1.7" | ||
gem "sass-rails", "~> 5.0" | ||
gem "selenium-webdriver" | ||
gem "spring" | ||
gem "spring-watcher-listen", "~> 2.0.0" | ||
gem "sqlite3", "~> 1.3.6" | ||
gem "web-console", ">= 3.3.0", group: :development | ||
end | ||
|
||
appraise "rails5.2" do | ||
gem "activerecord", "~> 5.2.3" | ||
gem "railties", "~> 5.2.3" | ||
gem "actionmailer", "~> 5.2.3" | ||
gem "bootsnap" | ||
gem "activestorage", "~> 5.2.3" | ||
gem "sass-rails" | ||
gem "byebug" | ||
gem "capybara", ">= 2.15" | ||
gem "chromedriver-helper" | ||
gem "jbuilder", "~> 2.5" | ||
gem "listen", ">= 3.0.5", "< 3.2" | ||
gem "puma", "~> 3.11" | ||
gem "rails", "~> 5.2.4", ">= 5.2.4.2" | ||
gem "sass-rails", "~> 5.0" | ||
gem "selenium-webdriver" | ||
gem "spring" | ||
gem "spring-watcher-listen", "~> 2.0.0" | ||
gem "sqlite3", "~> 1.3.6" | ||
gem "web-console", ">= 3.3.0", group: :development | ||
end | ||
|
||
appraise "rails6.0" do | ||
gem "rails", "~> 6.0.0" | ||
gem "bootsnap" | ||
gem "byebug" | ||
gem "capybara" | ||
gem "jbuilder" | ||
gem "listen", "~> 3.1.5" | ||
gem "puma", "~> 3.11" | ||
gem "sass-rails", "~> 5" | ||
gem "capybara", ">= 2.15" | ||
gem "jbuilder", "~> 2.7" | ||
gem "listen", ">= 3.0.5", "< 3.2" | ||
gem "puma", "~> 4.1" | ||
gem "rails", "~> 6.0.2", ">= 6.0.2.2" | ||
gem "sass-rails", ">= 6" | ||
gem "selenium-webdriver" | ||
gem "spring" | ||
gem "spring-watcher-listen" | ||
gem "turbolinks" | ||
gem "web-console", group: :development | ||
gem "spring-watcher-listen", "~> 2.0.0" | ||
gem "sqlite3", "~> 1.4" | ||
gem "web-console", ">= 3.3.0", group: :development | ||
gem "webdrivers" | ||
gem "webpacker" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding this issue, looks like it will failing for a while 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 Thanks for looking into this. I'm going to see if I can cucumber to log more details about what is going wrong here.