Update rails versions on Travis #367
Conversation
composerinteralia
force-pushed
the
test-suite
branch
8 times, most recently
from
a21b317 to
40ee56d
Compare
This commit gets the Travis build passing by: * Removing Rails 4.2 so we don't have to deal with bundler < 2 anymore * Bumping to latests Rails versions * Explicitly listing all gems that appear in the default Rails Gemfile
composerinteralia
force-pushed
the
test-suite
branch
from
40ee56d to
f1c6dbd
Compare
composerinteralia
changed the title
| gem "capybara", ">= 2.15" | ||
| gem "jbuilder", "~> 2.7" | ||
| gem "puma", "~> 4.1" | ||
| gem "rails", "~> 6.0.2", ">= 6.0.2.2" |
There was a problem hiding this comment.
Regarding this issue, looks like it will failing for a while 😞
There was a problem hiding this comment.
😢 Thanks for looking into this. I'm going to see if I can cucumber to log more details about what is going wrong here.
composerinteralia
force-pushed
the
test-suite
branch
from
dd174a9 to
fa9e787
Compare
50-character subject line
composerinteralia
force-pushed
the
test-suite
branch
2 times, most recently
from
23c616e to
e01270f
Compare
composerinteralia
force-pushed
the
test-suite
branch
3 times, most recently
from
fcf8007 to
d8f20fb
Compare
composerinteralia
force-pushed
the
test-suite
branch
from
d8f20fb to
1f50858
Compare
|
🎉 👍 |
|
Finally passing! I'm going to try to do a bit of cleanup, and then will ask you for a review @alextrueman. Thanks for your help here. |
|
@alextrueman I'm happy with this. If it looks good to you, I will go ahead an merge and then you can rebase on master to get the build passing on your PR. |
features/reloading.feature
Outdated
| @@ -4,8 +4,7 @@ Feature: | |||
| So that factory_bot_rails doesn't hold onto stale class references | |||
|
|
|||
| Scenario: Editing a model without editing the factory | |||
| When I successfully run `bundle exec rails new testapp -m ../../features/support/rails_template` | |||
| And I cd to "testapp" | |||
| When I create a new rails application | |||
| And I add "factory_bot_rails" from this project as a dependency | |||
| And I add "test-unit" as a dependency | |||
There was a problem hiding this comment.
Since we remove gem 'test-unit' do we need it now?
There was a problem hiding this comment.
Yeah I think you are correct that we can remove this, since test-unit already ships with Ruby. I will push up a commit that removes it to confirm.
| When /^I create a new rails application$/ do | ||
| options = "--skip-bootsnap --skip-javascript" | ||
| template = "-m ../../features/support/rails_template" | ||
| result = run_command("bundle exec rails new test_app #{options} #{template}") |
There was a problem hiding this comment.
What you think about creating an app in API mode? (.. --api) it will skip generating views, helpers, and assets. I think it might increase tests speed through making the app lighter 🤔
There was a problem hiding this comment.
I also think about:
--skip-action-mailer
--skip-active-storage
--skip-action-cable
for example, I might be wrong, but I think it might be helpful :)
There was a problem hiding this comment.
Yup, I think that is a good idea. The tests already got a bit faster by skipping js. And the fewer dependencies we have the less flaky these tests become (many of our failures are a result of some incompatible version of some gem).
I was also thinking it would be nice if we didn't need to install the development dependencies, since we don't ever start the app in development mode. Perhaps we could also --skip bundle and then manually run bundle install --without development.
I am going to merge this as is for now to get a passing build on master, and then open a separate issue to explore reducing the number of gems we need to install.
There was a problem hiding this comment.
Sounds good let's do it! 👍
There was a problem hiding this comment.
I opened #370
This commit gets the Travis build passing by: