Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a sieve to filter out packages based on ABI provided by s2i Thoth #1632

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Add a sieve to filter out packages based on ABI provided by s2i Thoth #1632

merged 1 commit into from
Feb 1, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Jan 29, 2021 •
edited
Loading

Related Issues and Dependencies

Related: #1631
Depends-On: thoth-station/storages#2193
Depends-On: thoth-station/storages#2195

This introduces a breaking change

  • No

@fridex fridex requested review from goern and sesheta as code owners January 29, 2021 10:12
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2021
@fridex
Copy link
Contributor Author

fridex commented Jan 29, 2021

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@fridex fridex changed the title Add a sieve to filter out packages based on ABI provided by s2i Thoth WPI: Add a sieve to filter out packages based on ABI provided by s2i Thoth Jan 29, 2021
@fridex fridex changed the title WPI: Add a sieve to filter out packages based on ABI provided by s2i Thoth WIP: Add a sieve to filter out packages based on ABI provided by s2i Thoth Jan 29, 2021
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2021
@fridex fridex force-pushed the sieve-thoth-s2i-compat branch from e144575 to ffde355 Compare January 29, 2021 12:32
@fridex fridex mentioned this pull request Jan 29, 2021
Closed
3 tasks
@fridex fridex changed the title WIP: Add a sieve to filter out packages based on ABI provided by s2i Thoth Add a sieve to filter out packages based on ABI provided by s2i Thoth Jan 29, 2021
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2021
@fridex
Copy link
Contributor Author

fridex commented Jan 29, 2021

/assign @KPostOffice

Kevin, please have a look at this one. It's based on your sieve for filtering out packages based on ABI symbols present in the environment. As the query for obtaining ABI symbols present in the container image was not specific to a concrete container image, this implementation tigthly couples Thoth s2i base container image with the query so we know exactly which Thoth s2i container image is used and what ABI symbols it offers.

Tests will fail as this change requires a new release of thoth-storages with linked PRs.

@fridex fridex mentioned this pull request Jan 29, 2021
Closed
@fridex fridex force-pushed the sieve-thoth-s2i-compat branch from f88dcfd to c93eadc Compare February 1, 2021 11:36
@fridex
Copy link
Contributor Author

fridex commented Feb 1, 2021

/retest

@fridex fridex force-pushed the sieve-thoth-s2i-compat branch from c93eadc to 88f91a7 Compare February 1, 2021 11:36
KPostOffice
KPostOffice approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sesheta
Copy link
Member

sesheta commented Feb 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2021
@fridex
Copy link
Contributor Author

fridex commented Feb 1, 2021

The tests will fail due to #1641. I will merge this. @KPostOffice Thanks for the review 👍

@fridex fridex merged commit a878cb1 into thoth-station:master Feb 1, 2021
@fridex fridex deleted the sieve-thoth-s2i-compat branch February 1, 2021 19:07
This was referenced Feb 15, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

@sesheta sesheta Awaiting requested review from sesheta sesheta is a code owner

@harshad16 harshad16 Awaiting requested review from harshad16

@saisankargochhayat saisankargochhayat Awaiting requested review from saisankargochhayat

Assignees

@KPostOffice KPostOffice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @sesheta @KPostOffice