Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ABI compat sieve so that it checks ABI symbols exported by Thoth base images #1631

Closed
3 tasks done
fridex opened this issue Jan 29, 2021 · 2 comments
Closed
3 tasks done

Comments

@fridex
Copy link
Contributor

fridex commented Jan 29, 2021

Is your feature request related to a problem? Please describe.

As of now, we check for "any" base image which matches provided configuration:

self.image_symbols = set(
self.context.graph.get_analyzed_image_symbols_all(
os_name=runtime_environment.operating_system.name,
os_version=runtime_environment.operating_system.version,
cuda_version=runtime_environment.cuda_version,
python_version=runtime_environment.python_version,
)
)

This can be extended so that the pipeline unit starts benefiting from the base image info as described in thoth-station/s2i-thoth#128

Describe the solution you'd like

@goern
Copy link
Member

goern commented Jan 29, 2021

/sig advisor
/sig documentation

+1

@fridex
Copy link
Contributor Author

fridex commented Feb 1, 2021

All the bullets are implemented. We can push components to stage and have this in place. Closing.

@fridex fridex closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants