Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error even if the logger is nil #72

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Handle error even if the logger is nil #72

merged 1 commit into from
Mar 29, 2021

Conversation

thomaspoignant
Copy link
Owner

Description

The error was not handled when we had no logger.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-comptible and/or changes current functionality)

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the Readme
  • I have followed the contributing guide

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant added the bug Something isn't working label Mar 29, 2021
@thomaspoignant thomaspoignant merged commit c101f1a into main Mar 29, 2021
@thomaspoignant thomaspoignant deleted the fix/handle-error-without-logger branch March 29, 2021 08:09
thomaspoignant added a commit that referenced this pull request Oct 11, 2021
@thomaspoignant
Handle error even if the logger is nil (#72)
a7dd5d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomaspoignant