Handle error even if the logger is nil (#72)

thomaspoignant · web-flow · commit c101f1a9ba97 · 2021-03-29T10:09:21.000+02:00
diff --git a/internal/notifier/notifier_webhook.go b/internal/notifier/notifier_webhook.go
@@ -63,8 +63,10 @@ func (c *WebhookNotifier) Notify(diff model.DiffCache, wg *sync.WaitGroup) {
 	}
 	response, err := c.HTTPClient.Do(&request)
 	// Log if something went wrong while calling the webhook.
-	if err != nil && c.Logger != nil {
-		c.Logger.Printf("[%v] error: while calling webhook: %v\n", date, err)
+	if err != nil {
+		if c.Logger != nil {
+			c.Logger.Printf("[%v] error: while calling webhook: %v\n", date, err)
+		}
 		return
 	}
 	defer response.Body.Close()

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,10 @@ func (c WebhookNotifier) Notify(diff model.DiffCache, wg sync.WaitGroup) {`
`63`	`63`	`}`
`64`	`64`	`response, err := c.HTTPClient.Do(&request)`
`65`	`65`	`// Log if something went wrong while calling the webhook.`
`66`		`- if err != nil && c.Logger != nil {`
`67`		`- c.Logger.Printf("[%v] error: while calling webhook: %v\n", date, err)`
	`66`	`+ if err != nil {`
	`67`	`+ if c.Logger != nil {`
	`68`	`+ c.Logger.Printf("[%v] error: while calling webhook: %v\n", date, err)`
	`69`	`+ }`
`68`	`70`	`return`
`69`	`71`	`}`
`70`	`72`	`defer response.Body.Close()`