Firmware boot failure after unloading and reloading driver #124
Comments
ZhendanYang
added
bug
ZhendanYang
changed the title
ZhendanYang
added
BYT
|
@lyakh could you help to check this issue? |
ZhendanYang
removed
APL
|
@ZhendanYang could you please point out where in the attached log the failure is seeing? Also, on which specific platforms / test boards and with which topology configurations has it been possible to reproduce this? |
|
@lyakh Looks like an earlier PM failure is breaking things. |
|
@lyakh I think the firmware cannot support PM on byt. PM should only be enabled on APL and GLK. Could you try to disable PM on BYT? @ranj063 Is runtime PM on BYT disabled by default? Or need manually disabling? @ZhendanYang Which firmware branch are you testing with? Could you share the latest result for both sof master and 1.2-stable branch? |
|
@mengdonglin yes - S0ix should be disabled on BYT Minnowboard, there should be a runtime flag set in platform data whether to enable or disable S0ix. @lyakh checking DMI name in sof-acpi-dev.c and then setting a flag to disable runtime_pm should be enough here. |
|
This issue still exists. |
mengdonglin
added
P2
|
Summary: Test steps: Test env: |
[ Upstream commit 25384ce ] This fixes the following warning at boot when the kernel is booted on a board with more CPU cores than was configured in NR_CPUS: smp_init_cpus: Core Count = 8 smp_init_cpus: Core Id = 0 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 0 at include/linux/cpumask.h:121 smp_init_cpus+0x54/0x74 Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 5.0.0-rc3-00015-g1459333f88a0 thesofproject#124 Call Trace: __warn$part$3+0x6a/0x7c warn_slowpath_null+0x35/0x3c smp_init_cpus+0x54/0x74 setup_arch+0x1c0/0x1d0 start_kernel+0x44/0x310 _startup+0x107/0x107 Signed-off-by: Max Filippov <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
Handle possible allocation failure in `user_ptr`.
Like commit 1cf3bfc ("bpf: Support 64-bit pointers to kfuncs") for s390x, add support for 64-bit pointers to kfuncs for LoongArch. Since the infrastructure is already implemented in BPF core, the only thing need to be done is to override bpf_jit_supports_far_kfunc_call(). Before this change, several test_verifier tests failed: # ./test_verifier | grep # | grep FAIL thesofproject#119/p calls: invalid kfunc call: ptr_to_mem to struct with non-scalar FAIL thesofproject#120/p calls: invalid kfunc call: ptr_to_mem to struct with nesting depth > 4 FAIL thesofproject#121/p calls: invalid kfunc call: ptr_to_mem to struct with FAM FAIL thesofproject#122/p calls: invalid kfunc call: reg->type != PTR_TO_CTX FAIL thesofproject#123/p calls: invalid kfunc call: void * not allowed in func proto without mem size arg FAIL thesofproject#124/p calls: trigger reg2btf_ids[reg->type] for reg->type > __BPF_REG_TYPE_MAX FAIL thesofproject#125/p calls: invalid kfunc call: reg->off must be zero when passed to release kfunc FAIL thesofproject#126/p calls: invalid kfunc call: don't match first member type when passed to release kfunc FAIL thesofproject#127/p calls: invalid kfunc call: PTR_TO_BTF_ID with negative offset FAIL thesofproject#128/p calls: invalid kfunc call: PTR_TO_BTF_ID with variable offset FAIL thesofproject#129/p calls: invalid kfunc call: referenced arg needs refcounted PTR_TO_BTF_ID FAIL thesofproject#130/p calls: valid kfunc call: referenced arg needs refcounted PTR_TO_BTF_ID FAIL thesofproject#486/p map_kptr: ref: reference state created and released on xchg FAIL This is because the kfuncs in the loaded module are far away from __bpf_call_base: ffff800002009440 t bpf_kfunc_call_test_fail1 [bpf_testmod] 9000000002e128d8 T __bpf_call_base The offset relative to __bpf_call_base does NOT fit in s32, which breaks the assumption in BPF core. Enable bpf_jit_supports_far_kfunc_call() lifts this limit. Note that to reproduce the above result, tools/testing/selftests/bpf/config should be applied, and run the test with JIT enabled, unpriv BPF enabled. With this change, the test_verifier tests now all passed: # ./test_verifier ... Summary: 777 PASSED, 0 SKIPPED, 0 FAILED Tested-by: Tiezhu Yang <[email protected]> Signed-off-by: Hengqi Chen <[email protected]> Signed-off-by: Huacai Chen <[email protected]>
Summary:
run the "soft/kmod_scripts/sof_bootone.sh" script, that means do the module reload one time, but boot failed on APL, BYT and CNL.
Environment：
kernel: sof-dev 64cf3e3
Log on APL:
boot_fail.log
The text was updated successfully, but these errors were encountered: