-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a separate branch instead of gbp-balances.toml, create separate files #27
Conversation
If the action runs in 5 seconds flat that should prevent race conditions, assuming the PR is being reviewed properly. I can’t think of being able to even merge 2 PRs in the space of 5 seconds unless you have them all lined up ready to go. |
It's happened to me before, lining up PRs while I wait for their CI to pass, but something else of note is that it might not be one person merging 2 PRs, but 2 people merging PRs at the same time. |
I'm closing this specific implementation, but separate branches WILL come! @stylemistake gave me a much better solution that completely eliminates the race conditions altogether (which this doesn't do, just obscures it) that I'm going to give a shot. |
Closes #23.
Addresses, but doesn't fix #24--if you merge two PRs in quick succession from the same person, you'll still meet the race condition.