Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GBP theft on your repo!? It's more likely than you think. #24

Closed
spessbro opened this issue Mar 12, 2021 · 4 comments · Fixed by #28
Closed

GBP theft on your repo!? It's more likely than you think. #24

spessbro opened this issue Mar 12, 2021 · 4 comments · Fixed by #28

Comments

@spessbro
Copy link

Apparently when merging prs quickly github-action will not let the last action finish before starting the next one causing it to overwrite the last gbp change.

tgstation/tgstation@bd40607
tgstation/tgstation@bd40607

these are the two instances of this happening i could find.

@optimumtact
Copy link
Member

this is so sad

@optimumtact
Copy link
Member

@Mothblocks

@Mothblocks
Copy link
Member

Mothblocks commented Mar 12, 2021

It's because createOrUpdateFileContents replaces the entire data, instead of diffs. It's a race condition against itself.

GitHub's API doesn't have a good solution for this, so we'll have to make the action use git directly.

@Mothblocks
Copy link
Member

What could also be done is instead of just one big gbp-balances.toml (since with diffs, it's possible to conflict), we take #23 and create a file for every contributor, with the contents being their points. I don't know if that's more or less stupid honestly, they wouldn't take up much space at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment