Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The action threatens maintainer response on prs with a net positive increase in gbp. #22

Closed
LemonInTheDark opened this issue Mar 1, 2021 · 1 comment

Comments

@LemonInTheDark
Copy link
Member

On one hand I get the constant reminder aspect, but this just seems wrong somehow.
Example: tgstation/tgstation#57273

@Mothblocks
Copy link
Member

So, the gbp-action end of this is fixed. It's not working on tgstation because there's a separate problem--there's a race condition.

The webhook and action fire off at the same time, and so gbp-action has to be slower than the webhook in order to see the new labels. If the auto labeler was a GitHub action, this bug wouldn't be happening. In the meantime, I think the best solution is just applying an artificial delay in the workflow file itself. However, that'll accentuate #24 until it's fixed, since that too is a race condition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants