New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip comment lines in the gemfile #3

Merged

stevenjackson merged 1 commit into testdouble:main from copiousfreetime:bugfix/parsing-gemfile

Aug 2, 2023

Contributor

copiousfreetime commented Jul 27, 2023

A standalone comment line causes the following to show up in the output:

#                              | 0.0.0.UNKNOWN | 1970-01-01

Turns out this is a parsing issue, and all comment lines should just be skipped.


          skip comment lines in the gemfile

Daniel-N-Huss approved these changes

View reviewed changes

Collaborator

Daniel-N-Huss left a comment

Seems like a reasonable addition to me!

The only counter-point I can think of is if there's commented out gems in the file, in which case we probably don't care about them anyways.

stevenjackson merged commit 82f9403 into testdouble:main

Daniel-N-Huss mentioned this pull request

Comments are not handled correctly #8

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet