Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are not handled correctly #8

Closed
alagos opened this issue Aug 4, 2023 · 1 comment
Closed

Comments are not handled correctly #8

alagos opened this issue Aug 4, 2023 · 1 comment

Comments

@alagos
Copy link

alagos commented Aug 4, 2023

I've just tried the gem with an old Gemfile I have for a project and it returns some funny results for some lines, like:

#gem 'activesupport', path: './vendor/activesupport'
gem 'tzinfo', '~> 1.1'

returns

#                              | 0.0.0.UNKNOWN | 1970-01-01
tzinfo                         | 2.0.6         | 2023-01-28

gem 'i18n-js'
gem 'i18n'#, '= 0.6.9'
gem 'sass-rails',   '~> 4.0.0'

returns:

i18n-js                        | 4.2.3         | 2023-03-29
i18n'#                         | 0.0.0.UNKNOWN | 1970-01-01
sass-rails                     | 6.0.0         | 2019-08-16

gem 'rqrcode'

# TODO: Just commenting for now.
#
#  We may refactor and re-enable at some point in the future, but not likely for
#  next 6 months.
#
# so if by any chance this is re-enabled at some point, just revert this commit
# to get back all the deleted code.
#
# gem "hubspot-ruby" # Ruby wrappers for the HubSpot REST API

# Middleware which cleans up invalid UTF8 characters in request URI and headers.
gem 'rack-utf8_sanitizer'

returns:

rqrcode                        | 2.2.0         | 2023-05-17
#                              | 0.0.0.UNKNOWN | 1970-01-01
#                              | 0.0.0.UNKNOWN | 1970-01-01
#                              | 0.0.0.UNKNOWN | 1970-01-01
rack-utf8_sanitizer            | 1.9.0         | 2023-07-05

  gem 'simplecov-cobertura', require: false

  # coveralls_reborn fork with 0.21.0 (next version requires ruby 2.5) plus
  # Buildkite support. In case the project is working with a newer ruby version
  # and you have to upgrade this gem, check this PR first:
  #
  # https://github.com/tagliala/coveralls-ruby-reborn/pull/43
  #
  # so, if by chance the BK support has been merged to the main repo, we won't
  # need this fork anymore.
  gem 'coveralls_reborn', git: 'https://github.com/privaterepo/coveralls-ruby-reborn.git',
                          branch: 'ruby-2-4-compatible', require: false

returns:

simplecov-cobertura            | 2.1.0         | 2021-12-14
#                              | 0.0.0.UNKNOWN | 1970-01-01
#                              | 0.0.0.UNKNOWN | 1970-01-01
coveralls_reborn               | 0.28.0        | 2023-07-22

there are a few more cases, but they follow more or less the same patterns as those samples mentioned now.

@Daniel-N-Huss
Copy link
Collaborator

Thanks for noting!

This got resolved in #3 and will work nicely in the next release 😄

@alagos alagos closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants