Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: honour go toolchain's verbose flag to print out logs #2624

Merged
merged 10 commits into from
Jul 5, 2024
+62 −27
Merged

feat: honour go toolchain's verbose flag to print out logs #2624

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
63072cf
chore: disable logging if the "-v" flag is not present
mdelapenya Jul 4, 2024
e0a3da7
chore: print ryuk is disabled using the logger
mdelapenya Jul 4, 2024
0d8b9a1
fix: lint
mdelapenya Jul 5, 2024
ee0404c
Merge branch 'main' into verbose-mode
mdelapenya Jul 5, 2024
43dfe77
fix: force verbosity in subprocess test
mdelapenya Jul 5, 2024
826b259
chore: include library version in banner
mdelapenya Jul 5, 2024
294e2d0
fix: terminate reusable container in tests
mdelapenya Jul 5, 2024
6f854db
fix: remove container out-of-process in the right place
mdelapenya Jul 5, 2024
0d00a07
chore: refresh github
mdelapenya Jul 5, 2024
2d13328
chore: simply check the reusable container is running without failures
mdelapenya Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: terminate reusable container in tests
  • Loading branch information
@mdelapenya
mdelapenya committed Jul 5, 2024
commit 294e2d0775c98dad3e2c9ffb09652661733678b4
1 change: 1 addition & 0 deletions generic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ func TestHelperContainerStarterProcess(t *testing.T) {
})
require.NoError(t, err)
require.True(t, nginxC.IsRunning())
terminateContainerOnEnd(t, ctx, nginxC)

origin, err := nginxC.PortEndpoint(ctx, nginxDefaultPort, "http")
require.NoError(t, err)
Expand Down
Loading