feat: honour go toolchain's verbose flag to print out logs #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kiview
previously approved these changes
Jul 5, 2024
Indeed. I'll add it to the initial banner: 2024/07/05 10:58:07 github.com/testcontainers/testcontainers-go - Connected to docker:
Server Version: 78+testcontainerscloud (via Testcontainers Desktop 1.15.0)
API Version: 1.43
Operating System: Ubuntu 20.04 LTS
Total Memory: 7407 MB
+ Testcontainers Go version: v0.31.0
Resolved Docker Host: tcp://127.0.0.1:61939
Resolved Docker Socket Path: /var/run/docker.sock
Test SessionID: 8cd3a6626cd58d51a66a9da017b40ba50c7130e74ee889f1a38ea4160e6a6f57
Test ProcessID: 00327949-4162-4994-b191-746e9b44b300 |
mdelapenya
commented
Jul 5, 2024
| cmd.Env = []string{"GO_WANT_HELPER_PROCESS=1"} | ||
| // force verbosity in subprocesses, so that the output is printed | ||
| cmd := exec.Command(os.Args[0], "-test.run=TestHelperContainerStarterProcess", "-test.v=true") | ||
| cmd.Env = append(os.Environ(), "GO_WANT_HELPER_PROCESS=1") |
There was a problem hiding this comment.
Having the environment will make this test more reliable, making it possible to run it locally (e.g., HOME var was not set)
mdelapenya
added
enhancement
mdelapenya
changed the title
bartsmykla
added a commit
to bartsmykla/kuma
that referenced
this pull request
Jul 10, 2024
- Add `-v` flag to transparent-proxy test runs: In `testcontainers-go` version 0.32.0, logging is disabled by default unless the `-v` flag is used. This change enables verbose logging for transparent-proxy tests to provide more detailed output, making it easier to debug issues such as test timeouts. - Increase GitHub Action job timeout to 60 minutes: Extended the timeout for the transparent-proxy tests GitHub Action job to 60 minutes to accommodate longer test runs and prevent premature job termination. - Adjust test schedule: Updated the schedule to run these tests 2 hours earlier, ensuring they align better with the team's workflow. ref. testcontainers/testcontainers-go#2624 Signed-off-by: Bart Smykla <[email protected]>
5 tasks
mdelapenya
added a commit
that referenced
this pull request
Jul 15, 2024
* main: fix: log output after context timeout (#2643) chore(deps): use "github.com/containerd/platforms" instead (#2638) chore(deps): bump google.golang.org/grpc to 1.64.1 (#2635) chore(deps): bump certifi from 2024.2.2 to 2024.7.4 (#2631) chore: prepare for next minor development cycle (0.33.0) chore: use new version (v0.32.0) in modules and examples feat: honour go toolchain's verbose flag to print out logs (#2624) Fix issues in BuildImage() (#2626) docs: indicate version for the Run function (#2627) chore: remove duplicated tests for config (#2628) Log retried errors (#2613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR checks if the verbose flags (
vor-test.v) are present in the current execution, keeping the default logger if it's passed. Else, a NOOP logger will be used for all the downstream calls.If a container defines its own logger in the container request struct, it will be honored.
Finally, we are including the library version in the initial banner in case users want to provide logs.
Why is it important?
Control the verbosity using standard Go flags
Related issues