Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pulsar): Support Apache Pulsar 4 #1355

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix(Pulsar): Support Apache Pulsar 4 #1355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc46d76
Update PulsarContainer script and defaults for compatibility
Jan 29, 2025
6cb5052
Update Pulsar image version and add new LTS 4.0.2 tests
Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Testcontainers.Pulsar/PulsarBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ namespace Testcontainers.Pulsar;
[PublicAPI]
public sealed class PulsarBuilder : ContainerBuilder<PulsarBuilder, PulsarContainer, PulsarConfiguration>
{
public const string PulsarImage = "apachepulsar/pulsar:3.0.6";
public const string PulsarImage = "apachepulsar/pulsar:3.0.9";

public const ushort PulsarBrokerDataPort = 6650;

public const ushort PulsarWebServicePort = 8080;

public const string StartupScriptFilePath = "/testcontainers.sh";

public const string SecretKeyFilePath = "/pulsar/secret.key";
public const string SecretKeyFilePath = "/tmp/secret.key";

public const string Username = "test-user";

Expand Down
2 changes: 1 addition & 1 deletion src/Testcontainers.Pulsar/PulsarContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ internal Task CopyStartupScriptAsync(CancellationToken ct = default)
startupScript.WriteLine("export brokerClientAuthenticationParameters=token:$(bin/pulsar tokens create --secret-key $PULSAR_PREFIX_tokenSecretKey --subject $superUserRoles)");
startupScript.WriteLine("export CLIENT_PREFIX_authParams=$brokerClientAuthenticationParameters");
startupScript.WriteLine("bin/apply-config-from-env.py conf/standalone.conf");
startupScript.WriteLine("bin/apply-config-from-env-with-prefix.py CLIENT_PREFIX_ conf/client.conf");
startupScript.WriteLine("bin/apply-config-from-env.py --prefix CLIENT_PREFIX_ conf/client.conf");
}

startupScript.Write("bin/pulsar standalone");
Expand Down
18 changes: 18 additions & 0 deletions tests/Testcontainers.Pulsar.Tests/PulsarContainerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,22 @@ public PulsarAuthConfiguration()
{
}
}

[UsedImplicitly]
public sealed class PulsarDefaultConfigurationLts4 : PulsarContainerTest
{
public PulsarDefaultConfigurationLts4()
: base(new PulsarBuilder().WithImage("apachepulsar/pulsar:4.0.2").Build(), false)
{
}
}

[UsedImplicitly]
public sealed class PulsarAuthConfigurationLts4 : PulsarContainerTest
{
public PulsarAuthConfigurationLts4()
: base(new PulsarBuilder().WithImage("apachepulsar/pulsar:4.0.2").WithAuthentication().Build(), true)
{
}
}
}