-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Pulsar): Support Apache Pulsar 4 #1355
fix(Pulsar): Support Apache Pulsar 4 #1355
Conversation
Replaced deprecated script arguments with updated ones to ensure proper configuration handling. Updated Pulsar image to version 3.0.8 and modified default file paths for better alignment with expected conventions.
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks like this PR relates to #1294 but with fewer necessary changes 👍.
@HofmeisterAn, would you prefer that I configure the tests to explicitly validate against both image versions (e.g., 3.0.X and 4.0.X), or is it sufficient to test exclusively with the latest default version (
3.0.X
)? Let me know how you'd like to proceed.
Usually, we test both versions if they are not compatible. We follow this pattern, which should be easy to apply to PulsarContainerTest
. I believe we just need to inherit from PulsarContainerTest
:
testcontainers-dotnet/tests/Testcontainers.MongoDb.Tests/MongoDbContainerTest.cs
Lines 101 to 108 in 888da44
[UsedImplicitly] | |
public sealed class MongoDbV5Configuration : MongoDbContainerTest | |
{ | |
public MongoDbV5Configuration() | |
: base(new MongoDbBuilder().WithImage("mongo:5.0").Build()) | |
{ | |
} | |
} |
Extending the tests would be great.
Sure, I'll do that. So we know that the two LTS versions work. |
Update the default Pulsar image to version 3.0.9 in the builder. Introduce two new test cases using Pulsar LTS 4.0.2: one for default configuration and another for authenticated configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙌.
What does this PR do?
Why is it important?
The new Apache Pulsar 4.0.X container image enforces stricter security by reducing user privileges. As a result, the
secret.key
file needs to be created in a location that can be written to in both 3.0.X and 4.0.X versions.This change ensures backward compatibility, which is a core principle of Testcontainers, while also taking advantage of the latest improvements in Pulsar 4.0.X.
How to test this PR
Open Question
@HofmeisterAn, would you prefer that I configure the tests to explicitly validate against both image versions (e.g., 3.0.X and 4.0.X), or is it sufficient to test exclusively with the latest default version (
3.0.X
)? Let me know how you'd like to proceed.