-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VHACD to latest (v4.1, tag 454913f) #896
Conversation
@Levi-Armstrong I'm not sure how to satisfy clang-tidy. Using NOLINTBEGIN/NOLINTEND is only supported from clang-format 14 onwards, and TESSERACT_COMMON_IGNORE_WARNINGS_PUSH/TESSERACT_COMMON_IGNORE_WARNINGS_POP doesn't work for analyzer checks. Any ideas? |
Clang tidy only provides a way to NOLINT individual lines, so there is three options. I recommend option 2, but if it is taking to long then I would be okay with option 3 and create an issue to fix it later since this is a utility.
|
c053455
to
0542bca
Compare
Thanks for the suggestions, I tried option:
But unfortunately, it doesn't seem to work, even though I accidentally found an issue by @Levi-Armstrong mentioning exactly this. Do you know why this is? Otherwise, I'll go for option 3, as with 654 warnings options 1&2 are a lot of work. |
@Levi-Armstrong friendly ping. |
I am not sure why it is not working, but I would just comment out the target_clang_tidy line in the CMakeLists.txt file. |
I will merge after the pipeline finishes. |
Thanks for making the update. |
This updates the outdated VHACD library to the latest version. It also removes OMP and OpenCL dependencies, as VHACD now works without these.