Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.xml #4

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Update package.xml #4

merged 1 commit into from
Jun 23, 2022

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong Levi-Armstrong requested a review from marip8 June 23, 2022 19:42
@Levi-Armstrong
Copy link
Contributor Author

@marip8 this is causing the build farm release to fail which is needed for it to install cmake.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #4 (84750af) into main (138acaa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          144       144           
=========================================
  Hits           144       144           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@marip8
Copy link
Contributor

marip8 commented Jun 23, 2022

Is this the only thing that is causing the build farm failure? I also saw something about not including cassert in the example in an email this morning:

/tmp/ws/src/boost_plugin_loader/examples/example.cpp: In function ‘int main(int, char**)’:
/tmp/ws/src/boost_plugin_loader/examples/example.cpp:34:3: error: ‘assert’ was not declared in this scope
   assert(printer_plugins.size() == 2);
   ^~~~~~
/tmp/ws/src/boost_plugin_loader/examples/example.cpp:34:3: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
/tmp/ws/src/boost_plugin_loader/examples/example.cpp:22:1:
+#include <cassert>
 
/tmp/ws/src/boost_plugin_loader/examples/example.cpp:34:3:
   assert(printer_plugins.size() == 2);
   ^~~~~~
make[2]: *** [examples/CMakeFiles/boost_plugin_loader_example.dir/build.make:63: examples/CMakeFiles/boost_plugin_loader_example.dir/example.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:208: examples/CMakeFiles/boost_plugin_loader_example.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
<== Failed to process package 'boost_plugin_loader':
  Command '['make']' returned non-zero exit status 2.

@Levi-Armstrong
Copy link
Contributor Author

Yea probably need to add that to if it is missing.

@Levi-Armstrong Levi-Armstrong merged commit 5e30bb1 into main Jun 23, 2022
@Levi-Armstrong Levi-Armstrong deleted the Levi-Armstrong-patch-1 branch June 23, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants