Adds check for gcloud executable in PATH #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallford
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
aaron-lane
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Thanks for the contribution @marshallford!
Can you please open an issue to track your larger question?
|
@aaron-lane See #336. Thanks! |
This was referenced Dec 17, 2019
aaron-lane
added a commit
that referenced
this pull request
Dec 18, 2019
SKozlovsky
pushed a commit
to SKozlovsky/terraform-google-project-factory
that referenced
this pull request
Dec 20, 2019
…form-google-modules#338, 6.1.0 to CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an unclear error message on apply when using this module in a TFE environment where
gcloudhad not be installed. I'm thinking a precondition error message would be helpful, especially for folks running TFE or using Terraform Cloud.A larger conversation: Can
modify-service-account.shbe rewritten to not rely on thegcloudcli? Perhaps a native module can make changes to the project SA?Thanks.