Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app_engine.feature_settings type and default #324

Closed
aaron-lane opened this issue Nov 28, 2019 · 2 comments · Fixed by #326
Closed

Update app_engine.feature_settings type and default #324

aaron-lane opened this issue Nov 28, 2019 · 2 comments · Fixed by #326
Assignees
Labels
bug Something isn't working enhancement New feature or request triaged Scoped and ready for work

Comments

@aaron-lane
Copy link
Contributor

modules/app_engine/variables.tf currently defines feature_settings as a generic list with a default of [{ enabled = true }]. The type should be updated to list(object{ split_health_checks = bool }) since feature_settings can only be defined once on google_app_engine_application and split_health_checks is the only valid argument. The default should be updated to { split_health_checks = true} since false enables legacy health checks.

https://www.terraform.io/docs/providers/google/r/app_engine_application.html#feature_settings

@aaron-lane aaron-lane added bug Something isn't working enhancement New feature or request triaged Scoped and ready for work labels Nov 28, 2019
@bharathkkb
Copy link
Member

@aaron-lane I can pick this up with #227

@aaron-lane
Copy link
Contributor Author

@bharathkkb I incorrectly specified a type of list(object{ split_health_checks = bool }) when it should have been object{ split_health_checks = bool} as feature_settings can only be specified once. Can you make the necessary change?

aaron-lane added a commit that referenced this issue Dec 18, 2019
SKozlovsky pushed a commit to SKozlovsky/terraform-google-project-factory that referenced this issue Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants