Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff suppress for time format to google_compute_resource_policies #779

Conversation

modular-magician
Copy link
Collaborator

closes issue #8460

This is probably a breaking change because some terraform apply commands won't go through if they have a wrong format. The regex will throw an error. But it also ensures that it's the correct format for the API.

Will write a test case for this into the PR if it's an approved solution.

Release Note Template for Downstream PRs (will be copied)

compute: fixed a permadiff caused by setting `start_time` in an incorrect H:mm format in `google_compute_resource_policies` resources

Derived from GoogleCloudPlatform/magic-modules#11486

…s` (#11486)

[upstream:b0849f05edb147b9a81a577048d72e30caa51516]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 16c3b8c into terraform-google-modules:master Aug 28, 2024
1 check passed
@modular-magician modular-magician deleted the downstream-pr-b0849f05edb147b9a81a577048d72e30caa51516 branch November 18, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_resource_policy inconsistent handling of start_time
1 participant