google_compute_resource_policy inconsistent handling of start_time

[assafrahav]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

internal build 2021.02.03-5 (mainline @355283235)

Affected Resource(s)

• google_compute_resource_policy

Terraform Configuration Files

resource "google_compute_resource_policy" "pd_snapshots" {
  name    = "${var.component}-snapshots"
  snapshot_schedule_policy {
    schedule {
      hourly_schedule {
        hours_in_cycle = var.snapshot_interval
        start_time     = "${local.snapshot_start}:00"
      }
    }
  }
}

Debug Output

Panic Output

Expected Behavior

Terraform applies the resource and remains stable on subsequent applications.
Alternatively, it can reject start time which isn't properly padded.
The important point is that the behavior should be consistent.

Actual Behavior

If local.snapshot_start is les than 10, then the resulting time string is h:00

The resource applies this without incident, however on subsequent diffing it interprets h:00 as being different than 0h:00 and plans to destroy&recreate the resource

Steps to Reproduce

1. create a google_compute_resource_policy resource with a start time < 10:00 and no leading 0
2. apply the config
3. apply terraform a second time - it will plan to destroy the resouce

Important Factoids

References

• #0000

b/308756082

[venkykuberan]

HH:MM is the expected format, please refer the doc https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_resource_policy#start_time

start_time - (Required) Time within the window to start the operations. It must be in format "HH:MM", where HH : [00-23] and MM : [00-00] GMT.

[assafrahav]

The issue is the provider isn't enforcing that requirement, it allows specifying the input in h:00 format.
Either the provider should CONSITENTLY treat h:00 as being the same as hh:00 or it should reject the input.

Accepting the input, but then getting into a destroy&create loop is not really acceptable behavior.

[assafrahav]

@venkykuberan I want to be sure you saw the last comment. I don't think it's correct to close this issue based on the current behavior of the resource.

I agree that h:00 is not in the prescribed format, but the resource needs to enforce this and thrown an error rather than enter this loop of creating & destroying.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

[rileykarson]

I had this issue flagged to reopen- reopened/unlocked/unassigned so it goes back to triage. We can consider suppressing the diff or disallowing inputs that'll be changed here.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.