Adds TQDMProgressBar in callbacks #610

shun-lin · 2019-10-21T07:35:09Z

Adding TQDMProgressBar in callbacks to make integration of TQDM (for progress bar) with tensorflow easy and configurable.

I also included ipython notebook usage / demo in the docs/tutorial folder.

Original source code:
https://github.com/bstriner/keras-tqdm
https://gist.github.com/ebursztein/5ff21d7600556de9946eac4a313344be

Original Pull Request :
#519
(sorry I messed up with merging and thus I have create another repo, the current one, to make pull request).

Based on the comments on 519:

I have ran bash tools/run_docker.sh -c 'make code-format' and all tests (3) passes.
I have updated callback README.

Thank you so much for your time!

review-notebook-app · 2019-10-21T07:35:16Z

Check out this pull request on

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

shun-lin · 2019-10-21T19:41:26Z

@seanpmorgan I have fixed a typo that is causing tests to fail, may you add the kokoro:force-run label again? Thank you so much for your time!

seanpmorgan · 2019-10-23T02:14:01Z

@seanpmorgan I have fixed a typo that is causing tests to fail, may you add the kokoro:force-run label again? Thank you so much for your time!

Hmmmm looks like there is still a formatting error that is found. Can you double check that any re-formats were committed/pushed

shun-lin · 2019-10-23T04:52:21Z

@seanpmorgan I have fixed a typo that is causing tests to fail, may you add the kokoro:force-run label again? Thank you so much for your time!

Hmmmm looks like there is still a formatting error that is found. Can you double check that any re-formats were committed/pushed

@seanpmorgan sorry I forgot to check sanity with bash tools/run_docker.sh -c 'make sanity-check' I have ran it and updated the code to pass all the sanity check, may you add kokoro:force-run label again? Thank you so much for your time!

Another question, I found out that when someone just look at the notebook, the private output of the kernal does not show the progress bar, where should I put the below screenshot (or if I should at all)? If it would be helpful, I am thinking of putting it under doc/tutorial/assets and then link it in the notebook. Thank you so much!
https://drive.google.com/file/d/1EEqoF37tknt5Gtl5GCp9_wDh5CRDqF15/view?usp=sharing

shun-lin · 2019-10-24T06:11:27Z

@Squadrick, @seanpmorgan when you have time may you review this PR? Thank you so much for your time!

seanpmorgan

Almost ready to merge, please see the comments.

tensorflow_addons/callbacks/README.md

docs/tutorials/tqdm_progress_bar.ipynb

seanpmorgan · 2019-10-29T17:42:58Z

Also just want to tag @bstriner. The repo has an MIT license so I think it's fine but wanted to tag for visibility

shun-lin · 2019-10-29T17:55:45Z

Also just want to tag @bstriner. The repo has an MIT license so I think it's fine but wanted to tag for visibility

Thanks Sean!

…tput of ipynb

shun-lin · 2019-10-29T23:09:13Z

@seanpmorgan I have updated this Pull Request based on your comments, may you run kokoro:force-run again and review the PR? Thank you so much for your time!

docs/tutorials/tqdm_progress_bar.ipynb

seanpmorgan

Thanks for the updates. So I tried running this in colab and didn't return the expected result. Any ideas?
https://colab.research.google.com/drive/1yIRkyVZEbOWtAzr2BKDoyDeCJFJinR7d

tensorflow_addons/callbacks/tqdm_progress_bar.py

docs/tutorials/tqdm_progress_bar.ipynb

shun-lin · 2019-10-30T01:52:33Z

Thanks for the updates. So I tried running this in colab and didn't return the expected result. Any ideas?
https://colab.research.google.com/drive/1yIRkyVZEbOWtAzr2BKDoyDeCJFJinR7d

Hi @seanpmorgan, I finally found out why! The tqdm version on that runtime is 4.28.1 instead of the latest 4.36.1. I think somewhere between 4.28.1 and 4.36.1 they fixed the issue, I will update the PR based on your comments and also make sure on colab it is installing version >=4.36.1, thank you so much for pointing this out!

Edit: found the solution!

… colab tf2.0 magic function

shun-lin · 2019-10-30T04:54:42Z

@seanpmorgan I have updated this PR based on your comments and found the solution to the issue mentioned (tqdm>=4.36.1 solves it). When you have time may you review it again? Thank you so much for your time!

tensorflow_addons/callbacks/tqdm_progress_bar.py

seanpmorgan

LGTM thanks for the contribution!

shun-lin added 4 commits October 20, 2019 13:20

import files and added new tutorial

99f1071

Update tqdm_progress_bar.ipynb

c4d8858

update ipynb notebook and py

3c774e1

final update before pull request

16b9ae7

shun-lin requested review from Squadrick and a team as code owners October 21, 2019 07:35

googlebot added the cla: yes label Oct 21, 2019

shun-lin mentioned this pull request Oct 21, 2019

[WIP] Added TQDMCallback in callbacks #519

Closed

seanpmorgan added the kokoro:force-run label Oct 21, 2019

kokoro-team removed the kokoro:force-run label Oct 21, 2019

fix typo!

3d41365

seanpmorgan added callbacks kokoro:force-run labels Oct 23, 2019

kokoro-team removed the kokoro:force-run label Oct 23, 2019

fix styling

2b48c68

seanpmorgan added the kokoro:force-run label Oct 23, 2019

kokoro-team removed the kokoro:force-run label Oct 23, 2019

seanpmorgan requested changes Oct 29, 2019

View reviewed changes

tensorflow_addons/callbacks/README.md Outdated Show resolved Hide resolved

seanpmorgan reviewed Oct 29, 2019

View reviewed changes

docs/tutorials/tqdm_progress_bar.ipynb Show resolved Hide resolved

docs/tutorials/tqdm_progress_bar.ipynb Show resolved Hide resolved

shun-lin added 2 commits October 29, 2019 15:16

Added demo image to tutorial, fixed addons/callbacks README, clean ou…

a9b7950

…tput of ipynb

added TQDMProgressBar to readme.md in callback

5996166

seanpmorgan added the kokoro:force-run label Oct 29, 2019

kokoro-team removed the kokoro:force-run label Oct 29, 2019

seanpmorgan reviewed Oct 30, 2019

View reviewed changes

docs/tutorials/tqdm_progress_bar.ipynb Show resolved Hide resolved

docs/tutorials/tqdm_progress_bar.ipynb Show resolved Hide resolved

seanpmorgan requested changes Oct 30, 2019

View reviewed changes

tensorflow_addons/callbacks/tqdm_progress_bar.py Outdated Show resolved Hide resolved

seanpmorgan reviewed Oct 30, 2019

View reviewed changes

docs/tutorials/tqdm_progress_bar.ipynb Show resolved Hide resolved

added try catch for import tqdm, add version of tqdm on tutorial, add…

6ac11a3

… colab tf2.0 magic function

shun-lin requested a review from seanpmorgan October 30, 2019 15:39

seanpmorgan requested changes Oct 30, 2019

View reviewed changes

tensorflow_addons/callbacks/tqdm_progress_bar.py Outdated Show resolved Hide resolved

put the import inside __init__ and check version

1ab1181

shun-lin requested a review from seanpmorgan October 30, 2019 17:39

seanpmorgan added the kokoro:force-run label Oct 30, 2019

kokoro-team removed the kokoro:force-run label Oct 30, 2019

seanpmorgan approved these changes Oct 30, 2019

View reviewed changes

seanpmorgan merged commit a10898e into tensorflow:master Oct 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds TQDMProgressBar in callbacks #610

Adds TQDMProgressBar in callbacks #610

shun-lin commented Oct 21, 2019

review-notebook-app bot commented Oct 21, 2019

shun-lin commented Oct 21, 2019

seanpmorgan commented Oct 23, 2019

shun-lin commented Oct 23, 2019

shun-lin commented Oct 24, 2019 •

edited

Loading

seanpmorgan left a comment

seanpmorgan commented Oct 29, 2019

shun-lin commented Oct 29, 2019

shun-lin commented Oct 29, 2019

seanpmorgan left a comment

shun-lin commented Oct 30, 2019 •

edited

Loading

shun-lin commented Oct 30, 2019

seanpmorgan left a comment

Adds TQDMProgressBar in callbacks #610

Adds TQDMProgressBar in callbacks #610

Conversation

shun-lin commented Oct 21, 2019

review-notebook-app bot commented Oct 21, 2019

shun-lin commented Oct 21, 2019

seanpmorgan commented Oct 23, 2019

shun-lin commented Oct 23, 2019

shun-lin commented Oct 24, 2019 • edited Loading

seanpmorgan left a comment

Choose a reason for hiding this comment

seanpmorgan commented Oct 29, 2019

shun-lin commented Oct 29, 2019

shun-lin commented Oct 29, 2019

seanpmorgan left a comment

Choose a reason for hiding this comment

shun-lin commented Oct 30, 2019 • edited Loading

shun-lin commented Oct 30, 2019

seanpmorgan left a comment

Choose a reason for hiding this comment

shun-lin commented Oct 24, 2019 •

edited

Loading

shun-lin commented Oct 30, 2019 •

edited

Loading