Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added TQDMCallback in callbacks #519

Closed
wants to merge 1 commit into from
Closed

[WIP] Added TQDMCallback in callbacks #519

wants to merge 1 commit into from

Conversation

shun-lin
Copy link
Contributor

Adding TQDMCallback in callbacks to make integration of TQDM (for progress bar) with tensorflow easy.

I also included ipython notebook and python3 script usage / demo in the examples folder.

Original source code:
https://github.com/bstriner/keras-tqdm

@shun-lin shun-lin requested review from Squadrick and a team as code owners September 18, 2019 05:13
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@shun-lin shun-lin changed the title Added TQDMCallback in callbacks [WIP] Added TQDMCallback in callbacks Sep 19, 2019
@seanpmorgan
Copy link
Member

Hi @shun-lin could you please format your code using:
bash tools/run_docker.sh -c 'make code-format'

Also please update the callbacks README, and rebase with master as examples/ now is in docs/tutorials/

@shun-lin
Copy link
Contributor Author

Hi Sean,

Thank you so much for your comments, I apologize that I have been busy with work recently but will work on this more when I have time. Thanks!

@shun-lin
Copy link
Contributor Author

Hi @seanpmorgan,

I have messed up merge and therefore I have created another repo to make another pull request, the request is here, #610. I will close this PR and when you have time may you review 610? Thank you so much for your time!

@shun-lin shun-lin closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants