Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial folder setup for callbacks #313

Merged
merged 3 commits into from
Jun 23, 2019
Merged

Initial folder setup for callbacks #313

merged 3 commits into from
Jun 23, 2019

Conversation

Squadrick
Copy link
Member

cc: @seanpmorgan @facaiy @WindQAQ

Closes #61.
Overriding #286 due to inactivity.

@Squadrick Squadrick requested a review from a team as a code owner June 21, 2019 08:22
@Squadrick Squadrick requested review from seanpmorgan and facaiy and removed request for facaiy and seanpmorgan June 22, 2019 17:24
seanpmorgan
seanpmorgan approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for putting this together. In general I'd prefer we have a first example when adding subpackages... but this one was discussed and seems like a great fit so hopefully adding it will encourage new additions.

@seanpmorgan seanpmorgan merged commit f126f91 into tensorflow:master Jun 23, 2019
@Squadrick Squadrick deleted the callbacks branch June 24, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

Assignees
No one assigned
Labels
callbacks cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new API type: Keras Callback
3 participants
@Squadrick @seanpmorgan @googlebot