-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new API type: Keras Callback #61
Comments
@seanpmorgan I would like work on this.. I am creating a branch in my fork to work on it.. do you want the single PR or multiple incremental ones ? Is there any Callback feature you are looking for ? i am thinking of implementing OneCycleLR Policy as an example. Thanks in advance P.S : My Understanding is to set up the folder structure with corresponding BUILD and README file for callbacks and then port a sample callback from tf.contrib using the latest tf2 keras api.. Is my understanding correct ? |
@Gokkulnath Any update on this? |
@Squadrick Thanks for reminding me. I am new to opensource contribution so was not sure how to proceed further. I have the folder structure ready. I need help on how the callbacks need to be implemented? Should i inherit from tf.keras.callbacks.Callback and create custom callback ? P.S: Shall i proceed with OneCycleLR or do you have an simpler Callback in mind ? |
@Gokkulnath Took a look at your folder structure, it's just what we need. One small nit, you need to set your name and email for your commits by using As for the implementation, you'll need to inherit from You can proceed with OneCycleLR since you've gotten started. |
Per #58 and our monthly discussion in March, Keras Callbacks seem like they are within scope for TF Addons. This new addition will require:
tensorflow_addons
which will hold keras callbacksThis will ideally include a new callback as an example, but not necessarily.
The text was updated successfully, but these errors were encountered: