Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added python implementation for GeLU #1154

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Added python implementation for GeLU #1154

merged 6 commits into from
Feb 26, 2020

Conversation

abhichou4
Copy link
Contributor

Refer #1114

@abhichou4 abhichou4 requested review from facaiy, seanpmorgan and a team as code owners February 25, 2020 21:33
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@abhichou4
Copy link
Contributor Author

Pardon my noob mistakes here. I'll try to be more careful.

gabrieldemarmiesse
gabrieldemarmiesse reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the pull request! I tried a while ago, but failed at finding the right formula 😄

tensorflow_addons/activations/gelu.py Show resolved Hide resolved
@gabrieldemarmiesse
Copy link
Member

Pardon my noob mistakes here. I'll try to be more careful.

No worries, it won't appear in the master branch because we squash the commits before merging.

If you want to know how to open multiple pull requests in a clean way, you can refer to the document we mention in the CONTRIBUTING: https://github.com/gabrieldemarmiesse/getting_started_open_source

@gabrieldemarmiesse gabrieldemarmiesse merged commit e926ecb into tensorflow:master Feb 26, 2020
@abhichou4 abhichou4 deleted the gelupy branch February 27, 2020 05:07
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@abhichou4
Added python implementation for GeLU (tensorflow#1154)
6cc1e2e 
* average callback and optimizers

* fixed links

* added SWA

* removed update, changed alias, 4 spaces

* added _gelu_py, test

* Delete average_optimizers_callback.ipynb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@seanpmorgan seanpmorgan Awaiting requested review from seanpmorgan

Assignees
No one assigned
Labels
activations cla: yes documentation tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhichou4 @gabrieldemarmiesse @googlebot