Enforce stricter per workflow limit #4326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Enforce stricter default per workflow limit based on our operational experience
More specifically, by default,
This PR only changes the default value, user can still set override to those configurations.
NOTE: there's no partial acceptance of workflow task response, meaning if a workflow task tries to schedule 3k activities and pending activity limit is 2k, 0 activity will be scheduled. Workflow task will be failed & workflow will enter a stuck state.
To check current usage,
total_signal_count
metric (for all operation tag values)activity_info_count
,child_info_count
,signal_info_count
&request_cancel_info_count
metric withoperation=ExecutionStats
How do I know if those limits are exceeded?
wf_too_many_pending_child_workflows
,wf_too_many_pending_activities
,wf_too_many_pending_cancel_requests
,wf_too_many_pending_external_workflow_signals
metric will be emitted.Why?
How did you test it?
N/A
Potential risks
Is hotfix candidate?