-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster configuration updates #2029
Conversation
…entation into AB/ClusterConfigUpdates
Co-authored-by: Dail Magee Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic config stuff looks good to me
Co-authored-by: David Reiss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, configuration part looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three nits, and this is good to go!
Co-authored-by: Dail Magee Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @aarohib !
What does this PR do?
archival
,namespaceDefaults
,dcReplication
,dynamicConfigClient
)Notes to reviewers
Thank you for taking the time to review this PR!
docs
folder are generated guides and not specific to the updates made in this PR. You can skip reviewing them.docs-src/clusters
,docs-src/concepts
,docs-src/references
, andkb
.