Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultJWTClaimMapper treat namespace as case sensitive #4244

Merged
merged 1 commit into from
Apr 27, 2023
Merged

defaultJWTClaimMapper treat namespace as case sensitive #4244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions common/authorization/default_jwt_claim_mapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (

"github.com/golang-jwt/jwt/v4"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common/primitives"

"go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
Expand All @@ -40,7 +41,7 @@ const (
defaultPermissionsClaimName = "permissions"
authorizationBearer = "bearer"
headerSubject = "sub"
permissionScopeSystem = "system"
permissionScopeSystem = primitives.SystemLocalNamespace
permissionRead = "read"
permissionWrite = "write"
permissionWorker = "worker"
Expand Down Expand Up @@ -110,8 +111,8 @@ func (a *defaultJWTClaimMapper) extractPermissions(permissions []interface{}, cl
a.logger.Warn(fmt.Sprintf("ignoring permission in unexpected format: %v", permission))
continue
}
namespace := strings.ToLower(parts[0])
if strings.EqualFold(namespace, permissionScopeSystem) {
namespace := parts[0]
if namespace == permissionScopeSystem {
claims.System |= permissionToRole(parts[1])
} else {
if claims.Namespaces == nil {
Expand Down
24 changes: 23 additions & 1 deletion common/authorization/default_jwt_claim_mapper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import (
"github.com/golang/mock/gomock"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
"go.temporal.io/server/common/primitives"

"go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
Expand Down Expand Up @@ -65,7 +66,7 @@ const (
)

var (
permissionsAdmin = []string{"system:admin", "default:read"}
permissionsAdmin = []string{primitives.SystemLocalNamespace + ":admin", "default:read"}
permissionsReaderWriterWorker = []string{"default:read", "default:write", "default:worker"}
)

Expand Down Expand Up @@ -163,6 +164,27 @@ func (s *defaultClaimMapperSuite) testTokenWithAdminPermissions(alg keyAlgorithm
s.Equal(RoleReader, defaultRole)
}

func (s *defaultClaimMapperSuite) TestNamespacePermissionCaseSensitive() {
tokenString, err := s.tokenGenerator.generateToken(RSA,
testSubject, []string{"Temporal-system:admin", "Foo:read"}, errorTestOptionNoError)
s.NoError(err)
authInfo := &AuthInfo{
AddBearer(tokenString),
nil,
nil,
"",
"",
}
claims, err := s.claimMapper.GetClaims(authInfo)
s.NoError(err)
s.Equal(testSubject, claims.Subject)
s.Equal(RoleUndefined, claims.System) // no system role
s.Equal(2, len(claims.Namespaces))
// claims contain namespace role for 'Foo', not for 'foo'.
s.Equal(RoleReader, claims.Namespaces["Foo"])
s.Equal(RoleAdmin, claims.Namespaces["Temporal-system"])
}

func (s *defaultClaimMapperSuite) TestTokenWithReaderWriterWorkerPermissionsRSA() {
s.testTokenWithReaderWriterWorkerPermissions(RSA)
}
Expand Down