defaultJWTClaimMapper treat namespace as case sensitive #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
force-pushed
the
jwt_claim_namespace
branch
from
a397825 to
cbca4b4
Compare
dnr
reviewed
Apr 27, 2023
dnr
approved these changes
Apr 27, 2023
change system namespace from `system` to `temporal-system` and make it case sensitive
yiminc
force-pushed
the
jwt_claim_namespace
branch
from
cbbee24 to
f400099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Change defaultJWTClaimMapper treat namespace as case sensitive.
Change system namespace from
systemtotemporal-systemand make it case sensitive.Why?
Namespace in temporal is case sensitive.
How did you test it?
Unit test
Potential risks
If the JWT generator produce token using case insensitive namespace name, that will not work with this change.
Is hotfix candidate?
No