Add metrics scopes for the archival queue #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we hold on this one? I am making a big change to metrics |
Hmm, this is blocking my ability to test the archival queue--any way I can make it compatible with your change? |
MichaelSnowden
force-pushed
the
durable-archival/metrics-scope
branch
from
40b690a to
bbd2353
Compare
yycptt
reviewed
Dec 2, 2022
MichaelSnowden
force-pushed
the
durable-archival/metrics-scope
branch
from
bbd2353 to
2ca23ec
Compare
yux0
approved these changes
Dec 6, 2022
yycptt
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added some metrics scopes for the archival queue.
Why?
I added these changes because our queue processor will crash if it can't find the metrics scope for the archival category.
How did you test it?
I ran the archival queue in our integration testing environment and watched the errors go away.
Potential risks
This isn't wired into any production entry points. However, it will increase
NumCommonScopes. It doesn't look like anyone is using this variable outside of tests, though.Is hotfix candidate?
No.