Add metrics scopes for the archival queue

temporalio · Nov 7, 2022 · 40b690a · 40b690a
1 parent b300010
commit 40b690a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/common/metrics/defs.go b/common/metrics/defs.go
@@ -832,6 +832,11 @@ const (
 	// DeadlockDetectorScope is a scope for deadlock detector
 	DeadlockDetectorScope
 
+	// PersistenceGetArchivalTaskScope tracks GetArchivalTask calls made by service to persistence layer
+	PersistenceGetArchivalTaskScope
+	// PersistenceGetArchivalTasksScope tracks GetArchivalTasks calls made by service to persistence layer
+	PersistenceGetArchivalTasksScope
+
 	NumCommonScopes
 )
 
@@ -1401,6 +1406,8 @@ var ScopeDefs = map[ServiceIdx]map[int]scopeDefinition{
 		PersistenceGetVisibilityTasksScope:                {operation: "GetVisibilityTasks"},
 		PersistenceCompleteVisibilityTaskScope:            {operation: "CompleteVisibilityTask"},
 		PersistenceRangeCompleteVisibilityTasksScope:      {operation: "RangeCompleteVisibilityTask"},
+		PersistenceGetArchivalTaskScope:                   {operation: "GetArchivalTask"},
+		PersistenceGetArchivalTasksScope:                  {operation: "GetArchivalTasks"},
 		PersistenceGetReplicationTaskScope:                {operation: "GetReplicationTask"},
 		PersistenceGetReplicationTasksScope:               {operation: "GetReplicationTasks"},
 		PersistenceCompleteReplicationTaskScope:           {operation: "CompleteReplicationTask"},

diff --git a/common/persistence/persistenceMetricClients.go b/common/persistence/persistenceMetricClients.go
@@ -408,6 +408,8 @@ func (p *executionPersistenceClient) GetHistoryTask(
 		scopeIdx = metrics.PersistenceGetVisibilityTaskScope
 	case tasks.CategoryIDReplication:
 		scopeIdx = metrics.PersistenceGetReplicationTaskScope
+	case tasks.CategoryIDArchival:
+		scopeIdx = metrics.PersistenceGetArchivalTaskScope
 	default:
 		return nil, serviceerror.NewInternal(fmt.Sprintf("unknown task category type: %v", request.TaskCategory))
 	}
@@ -440,6 +442,8 @@ func (p *executionPersistenceClient) GetHistoryTasks(
 		scopeIdx = metrics.PersistenceGetVisibilityTasksScope
 	case tasks.CategoryIDReplication:
 		scopeIdx = metrics.PersistenceGetReplicationTasksScope
+	case tasks.CategoryIDArchival:
+		scopeIdx = metrics.PersistenceGetArchivalTasksScope
 	default:
 		return nil, serviceerror.NewInternal(fmt.Sprintf("unknown task category type: %v", request.TaskCategory))
 	}