Skip to content

Commit

Permalink
Updates Dynamic Config reference (#2123)
Browse files Browse the repository at this point in the history
* Fixes bad update that published an old version of the dyanmic config reference.

* fixes header level
  • Loading branch information
aarohib authored Jun 20, 2023
1 parent 3b6b4e4 commit 0f622a1
Show file tree
Hide file tree
Showing 13 changed files with 244 additions and 242 deletions.
18 changes: 11 additions & 7 deletions ASSEMBLY_REPORT.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion assembly/guide-configs/references/configuration.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"id": "configuration",
"file_dir": "references",
"title": "Temporal Cluster configuration reference",
"sidebar_label": "Cluster config",
"sidebar_label": "Cluster configuration",
"description": "Much of the behavior of a Temporal Cluster is configured using the `development.yaml` file.",
"toc_max_heading_level": 4,
"add_tabs_support": false,
Expand Down
16 changes: 16 additions & 0 deletions assembly/guide-configs/references/dynamic-configuration.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"file_name": "dynamic-configuration.md",
"id": "dynamic-configuration",
"file_dir": "references",
"title": "Temporal Cluster dynamic configuration reference",
"sidebar_label": "Dynamic configuration",
"description": "Temporal Cluster provides dynamic configuration keys that you can update and apply to a running Cluster without restarting your services.",
"toc_max_heading_level": 4,
"add_tabs_support": false,
"sections": [
{
"type": "p",
"id": "references/dynamic-configuration"
}
]
}
2 changes: 1 addition & 1 deletion docs-src/concepts/what-is-a-workflow-execution.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ To protect the system, Temporal enforces a maximum of 50,000 pending Activities,
Currently, there is no limit on the total number of Signals that a Workflow Execution can receive. <!--From Temporal server v1.21, the default maximum number of Signals that a Workflow Execution can receive is 10000. -->
These limits are set with the following [dynamic configuration keys](https://github.com/temporalio/temporal/blob/master/service/history/configs/config.go):

- `limit.numPendingChildExecutions.error`
- `limit.numPendingActivities.error`
- `limit.numPendingChildExecutions.error`
- `limit.numPendingSignals.error`
- `limit.numPendingCancelRequests.error`
- `history.maximumSignalsPerExecution`
Expand Down
2 changes: 1 addition & 1 deletion docs-src/concepts/what-is-cluster-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ All dynamic configuration keys provided by Temporal have default values that are
You can override the default values by setting different values for the keys in a YAML file and setting the [dynamic configuration client](/references/configuration#dynamicconfigclient) to poll this file for updates.
Setting dynamic configuration for your Cluster is optional.

Setting overrides for some configuration keys upates the Cluster configuration immediately.
Setting overrides for some configuration keys updates the Cluster configuration immediately.
However, for configuration fields that are checked at startup (such as thread pool size), you must restart the server for the changes to take effect.

Use dynamic configuration keys to fine-tune your self-deployed Cluster setup.
Expand Down
2 changes: 1 addition & 1 deletion docs-src/references/dynamic-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ If the number of queries made to the Persistence store exceeds the dynamic confi
| `system.visibilityPersistenceMaxReadQPS` | Int | Maximum number queries per second that Visibility database can receive for read operations. | 9000 |
| `system.visibilityPersistenceMaxWriteQPS` | Int | Maximum number of queries per second that Visibility database can receive for write operations. | 9000 |

#### Activity and Workflow default policy setting
### Activity and Workflow default policy setting

You can define default values for Activity and Workflow [Retry Policies](/concepts/what-is-a-retry-policy) at the Cluster level with the following dynamic configuration keys.

Expand Down
4 changes: 2 additions & 2 deletions docs/concepts/clusters.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0f622a1

Please sign in to comment.