Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a sanitization to replace / with - #3167

Merged
merged 1 commit into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

### 2.13.2 (TBD)
- Bugfix: Replaced `/` characters with a `-` when the authenticator service creates the kubeconfig in the Telepresence cache.

- Feature: Configurable strategy (`auto`, `powershell`. or `registry`) to set the global DNS search path on Windows. Default
is `auto` which means try `powershell` first, and if it fails, fall back to `registry`.
Expand Down Expand Up @@ -37,7 +38,7 @@
- Feature: There's a new --address flag to the intercept command allowing users to set the target IP of the intercept.

- Feature: The new flags `--docker-build`, and `--docker-build-opt` was added to `telepresence intercept` to facilitate a
docker run directly from a docker context.
docker run directly from a docker context.

- Bugfix: Using `telepresence intercept --docker-run` now works with a container based daemon started with `telepresence connect --docker`

Expand Down
1 change: 1 addition & 0 deletions pkg/client/docker/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ func enableK8SAuthenticator(ctx context.Context) error {
// Store the file using its context name under the <telepresence cache>/kube directory
const kubeConfigs = "kube"
kubeConfigFile := config.CurrentContext
kubeConfigFile = strings.ReplaceAll(kubeConfigFile, "/", "-")
kubeConfigDir := filepath.Join(filelocation.AppUserCacheDir(ctx), kubeConfigs)
if err = os.MkdirAll(kubeConfigDir, 0o700); err != nil {
return err
Expand Down