added a sanitization to replace / with - #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblbeck
force-pushed
the
jbeck/sanitize_kubeconfig_names
branch
2 times, most recently
from
84dd2bc to
447894a
Compare
jacoblbeck
added
the
ok to test
jacoblbeck
requested review from
a team and
thallgren
and removed request for
a team
jacoblbeck
force-pushed
the
jbeck/sanitize_kubeconfig_names
branch
from
447894a to
124ef8b
Compare
jacoblbeck
added
ok to test
github-actions
bot
removed
the
ok to test
thallgren
approved these changes
May 10, 2023
Signed-off-by: jacoblbeck <[email protected]>
jacoblbeck
force-pushed
the
jbeck/sanitize_kubeconfig_names
branch
from
124ef8b to
5fe9ecf
Compare
jacoblbeck
added
the
ok to test
github-actions
bot
removed
the
ok to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS automatically adds a
/in the cluster names, so i'm replacing all/with a-so when the authenticator service runs it properly creates the file instead of a pathChecklist
./CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.