Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to the uninstall-agents pre-delete hook. #2937

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add timeouts to the uninstall-agents pre-delete hook. #2937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

### 2.9.6 (TBD)

- Bugfix: A timeout was added to the pre-delete hook `uninstall-agents`, so that a helm uninstall doesn't
hang when there is no running traffic-manager.

- Change: If the cluster is Kubernetes 1.21 or later, the mutating webhook will find the correct namespace
using the label `kubernetes.io/metadata.name` rather than `app.kuberenetes.io/name`.

Expand Down
2 changes: 1 addition & 1 deletion charts/telepresence/templates/pre-delete-hook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
- sh
- -c
args:
- 'curl --fail --request DELETE https://{{ .Values.agentInjector.name }}.{{ include "traffic-manager.namespace" . }}/uninstall || exit 0'
- 'curl --fail --connect-timeout 5 --max-time 60 --request DELETE https://{{ .Values.agentInjector.name }}.{{ include "traffic-manager.namespace" . }}/uninstall || exit 0'
volumes:
- name: secret-volume
secret:
Expand Down