Add timeouts to the uninstall-agents pre-delete hook. #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm uninstall of a failed installation took a vary long time because the `uninstall-agents` job got stuck when it didn't get any responses from the agent-injector. Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
requested review from
a team and
raphaelreyna
and removed request for
a team
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
|
This was approved before I split the PR into smaller ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helm uninstall of a failed installation took a vary long time because the
uninstall-agentsjob got stuck when it didn't get any responses from the agent-injector.Checklist
./CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.