Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag published images #1502

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Tag published images #1502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tekton/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ spec:
done

# Publish images and create release.yaml
ko resolve --preserve-import-paths -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > /workspace/output/bucket/latest/release.yaml
ko resolve --preserve-import-paths -t $(inputs.params.versionTag) -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > /workspace/output/bucket/latest/release.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this.

Tags are already added today - see L199-212.

The tagging is done using the gcloud client, and I would love to move away from it, to make this task more portable. I would be happy to apply the tags using ko, but I don't think we can handle the regional tags with ko.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, since we do not create regional release files, I doubt the regional images are ever used by anyone. I wonder if we should just push the images to gcr.io (which is hosted in the US for now, according to docs) - and we could move the bit that pushes to different regions to an optional step / task which is only executed when the target registry is gcr.io.
@bobcatfish @vdemeester thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrittoli we could to the initial push with the tag to gcr.io using ko (so no gcloud), and do the replication with the gcloud binary separately (maybe in async pipeline/task even 😉)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdemeester that sounds good to me. @adshmh this patch as it is now pushes the tag twice to gcr.io. Could you please remove the gcloud one - leaving the regions. We can move the region bit to a separate task in a different PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrittoli let's get this one merged, I'll do a quick follow-up 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reviews. I will submit another PR to remove the gcloud tagging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adshmh see #1536 😅

volumeMounts:
- name: gcp-secret
mountPath: /secret
Expand Down