Tag published images #1502
Tag published images #1502
Conversation
To make it easier to identify the installed version of tekton pipeline, built images are now individually tagged with the specified release. Partly addresses tektoncd#1232. This PR uses ko to tag the built images. Unfortunatelty, ko does not specify the image tag on the output (only specifies the digest). Therefore, what remains to be done is either: a) log an issue against ko to include the tags, or b) manually process the output of ko and append tags Signed-off-by: Arash Deshmeh <[email protected]>
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XS
|
Hi @adshmh. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
needs-ok-to-test
| @@ -146,7 +146,7 @@ spec: | |||
| done | |||
|
|
|||
| # Publish images and create release.yaml | |||
| ko resolve --preserve-import-paths -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > /workspace/output/bucket/latest/release.yaml | |||
| ko resolve --preserve-import-paths -t $(inputs.params.versionTag) -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > /workspace/output/bucket/latest/release.yaml | |||
There was a problem hiding this comment.
Thank you for this.
Tags are already added today - see L199-212.
The tagging is done using the gcloud client, and I would love to move away from it, to make this task more portable. I would be happy to apply the tags using ko, but I don't think we can handle the regional tags with ko.
There was a problem hiding this comment.
To be honest, since we do not create regional release files, I doubt the regional images are ever used by anyone. I wonder if we should just push the images to gcr.io (which is hosted in the US for now, according to docs) - and we could move the bit that pushes to different regions to an optional step / task which is only executed when the target registry is gcr.io.
@bobcatfish @vdemeester thoughts?
There was a problem hiding this comment.
@afrittoli we could to the initial push with the tag to gcr.io using ko (so no gcloud), and do the replication with the gcloud binary separately (maybe in async pipeline/task even 😉)
There was a problem hiding this comment.
@vdemeester that sounds good to me. @adshmh this patch as it is now pushes the tag twice to gcr.io. Could you please remove the gcloud one - leaving the regions. We can move the region bit to a separate task in a different PR.
There was a problem hiding this comment.
@afrittoli let's get this one merged, I'll do a quick follow-up 😉
There was a problem hiding this comment.
Thank you for the reviews. I will submit another PR to remove the gcloud tagging.
tekton-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
To make it easier to identify the installed version of tekton pipeline,
built images are now individually tagged with the specified release.
Partly addresses #1232.
This PR uses ko to tag the built images. Unfortunatelty, ko does not
specify the image tag on the output (only specifies the digest).
Therefore, what remains to be done is either:
a) log an issue against ko to include the tags, or
b) manually process the output of ko and append tags
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes