Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom failure patterns in dmesg test check #2786

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Allow custom failure patterns in dmesg test check #2786

merged 1 commit into from
Apr 30, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Mar 25, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • adjust plugin docstring
  • mention the version
  • include a release note

@happz happz added the area | check Test check implementation label Mar 25, 2024
@happz happz added this to the 1.33 milestone Mar 25, 2024
@happz happz force-pushed the dmesg-configurable-patterns branch 2 times, most recently from 642badc to 37f75e5 Compare April 2, 2024 08:32
@happz happz force-pushed the dmesg-configurable-patterns branch from 37f75e5 to d6b6d93 Compare April 10, 2024 12:29
@happz happz added the ci | full test Pull request is ready for the full test execution label Apr 10, 2024
psss
psss requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Looks good. Just two typos.

psss
psss reviewed Apr 29, 2024
View reviewed changes
@psss psss force-pushed the dmesg-configurable-patterns branch from be8980e to 159b37c Compare April 29, 2024 22:05
@psss psss changed the title Allow custom failure patterns in dmesg test check Allow custom failure patterns in dmesg test check Apr 29, 2024
@psss psss self-assigned this Apr 30, 2024
@psss psss merged commit 159b37c into main Apr 30, 2024
20 checks passed
@psss psss deleted the dmesg-configurable-patterns branch April 30, 2024 05:29
@juk juk mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
area | check Test check implementation ci | full test Pull request is ready for the full test execution
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.
2 participants
@happz @psss