Improve Better Victory Screen Compatibility #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinwessels
force-pushed
the
bvs-compat-improved
branch
from
936525d to
9a5f3cc
Compare
|
Removed the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two small problems
The main goal is that it changes the
disable_rocket_victory()to always set theset_no_victoryinsilo-scriptandbetter-victory-screen. The reason is explained in the comments. If this is left as-is it's not that bad. Rather, until K2 compat is released, a BVS victory GUI will be shown on a regular rocket launch (once). The K2 victory will still trigger as per normal.It also adds a
global.finished, because BVS does not set either the two conditions you currently check for. If this is not added then nothing will go wrong because BVS does this internally already. But it will prevent edge cases, for example if BVS is removed after FF victory is achieved, then you'll be able to trigger the victory again.