Improve Better Victory Screen Compatibility (#23)

Adds a global.finished, because BVS does not set either the two conditions you currently check for. If this is not added then nothing will go wrong because BVS does this internally already. But it will prevent edge cases, for example if BVS is removed after FF victory is achieved, then you'll be able to trigger the victory again. --------- Co-authored-by: Tom Burrows <[email protected]>
tburrows13 · Apr 14, 2024 · 2fb362f · 2fb362f
1 parent 7c7f101
commit 2fb362f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/scripts/endgame.lua b/scripts/endgame.lua
@@ -8,10 +8,11 @@ local function on_rocket_launched(event)
   local rocket = event.rocket
   if not (rocket and rocket.valid) then return end
 
-  if game.finished or game.finished_but_continuing then return end
+  if game.finished or game.finished_but_continuing or global.finished then return end
 
   local inventory = rocket.get_inventory(defines.inventory.rocket)
   if inventory.get_item_count("ff-interstellar-communicator") > 0 then
+    global.finished = true
 
     if remote.interfaces["better-victory-screen"] and remote.interfaces["better-victory-screen"]["trigger_victory"] then
       remote.call("better-victory-screen", "trigger_victory", rocket.force)
@@ -51,4 +52,4 @@ Endgame.events = {
 Endgame.on_init = disable_rocket_victory
 Endgame.on_configuration_changed = disable_rocket_victory
 
-return Endgame
+return Endgame