Prevent global shortcut activation from repeating on Windows #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently, when global shortcuts are registered on Windows, the
MOD_NOREPEAT
flag is not included which causes the global shortcut to repeatedly activate when the key is pressed down (similar to pressing and holding a single key on the keyboard, which causes the key press to repeat). To mimic the functionality of how shortcuts are managed in other platforms, we may add theMOD_NOREPEAT
flag by default.Reference: https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-registerhotkey
Relevant Discord thread: https://discord.com/channels/616186924390023171/807549941936816148/1033114071832207471
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information