Prevent global shortcut activation from repeating on Windows (#602)

* Add MOD_NOREPEAT to Windows global shortcut manager * Add .changes
tauri-apps · Oct 24, 2022 · d15a756 · d15a756
1 parent 775974d
commit d15a756
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/windows-global-shortcut-no-repeat.md b/.changes/windows-global-shortcut-no-repeat.md
@@ -0,0 +1,5 @@
+---
+"tao": patch
+---
+
+Default to MOD_NOREPEAT for registering global shortcuts / hotkeys via win32 RegisterHotKey on Windows. This prevents shortcuts from repeatedly activating when the accelerator is pressed and held down, and ensures that we maintain platform-agnostic consistency.
diff --git a/src/platform_impl/windows/global_shortcut.rs b/src/platform_impl/windows/global_shortcut.rs
@@ -24,7 +24,7 @@ impl ShortcutManager {
     accelerator: Accelerator,
   ) -> Result<RootGlobalShortcut, ShortcutManagerError> {
     unsafe {
-      let mut converted_modifiers = Default::default();
+      let mut converted_modifiers = MOD_NOREPEAT;
       let modifiers: ModifiersState = accelerator.mods;
       if modifiers.shift_key() {
         converted_modifiers |= MOD_SHIFT;