Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: options to disable individual window controls, closes #116 #574

Merged
merged 28 commits into from
Oct 11, 2022
Merged

feat: options to disable individual window controls, closes #116 #574

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e75a415
feat(window): implement `minimizable` and `closable` for macOS
caesar Sep 29, 2022
ddb9f2b
feat(window): examples for `minimizable` and `closable`
caesar Sep 29, 2022
d88a1e0
fix(window): stub `minimizable` and `resizable` for other platforms
caesar Sep 29, 2022
bc24307
lint: run cargo fmt
caesar Sep 29, 2022
78922f5
feat(window): implement `closable` for Linux
caesar Oct 2, 2022
1ef6498
refactor: rename parameter
caesar Oct 2, 2022
d6bb6bf
feat(window): implement `maximizable` for macOS
caesar Oct 4, 2022
458d835
feat(window): implement `minimizable` for Windows
kleincyber Oct 4, 2022
d78a27c
fix: edit bitflag for minimizable and move line
kleincyber Oct 6, 2022
e99ce60
fix(window): initial `minimzable` value on Windows
caesar Oct 7, 2022
486e837
feat(window): implement `maximizable` for Windows
caesar Oct 7, 2022
6a70db6
docs(window): correct platform-specific notes
caesar Oct 7, 2022
db72a71
feat(window): implement `closable` for Windows
caesar Oct 8, 2022
4bd48ab
fix(window): missing `mut`
caesar Oct 8, 2022
9311888
chore: add changefile
caesar Oct 8, 2022
0cdb86c
docs(window): correct platform-specific notes
caesar Oct 8, 2022
785a970
docs(window): improve docs for window control toggles
caesar Oct 10, 2022
504c1b6
refactor (examples): move window control examples into window_debug.rs
caesar Oct 10, 2022
f86d04f
refactor(window): move `set_closable` impl on Windows to `WindowFlags…
caesar Oct 10, 2022
0d13731
chore: cargo fmt
caesar Oct 10, 2022
33815f3
chore: update changefile
caesar Oct 10, 2022
6c2df8a
chore: remove println
caesar Oct 10, 2022
50a2b87
fix with_closable on Windows
amrbashir Oct 11, 2022
cb3858c
Update src/platform_impl/linux/window.rs
amrbashir Oct 11, 2022
dd26f66
Update src/platform_impl/linux/window.rs
amrbashir Oct 11, 2022
b47d60b
Update src/window.rs
amrbashir Oct 11, 2022
ae89533
Merge branch 'dev' into disable-window-controls
amrbashir Oct 11, 2022
2372e45
update flags
amrbashir Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update changefile 
Co-authored-by: Amr Bashir <[email protected]>
  • Loading branch information
@caesar @amrbashir
caesar and amrbashir authored Oct 10, 2022
commit 33815f301d33e6aa3fb8b510a56210fe8f1dc11c
6 changes: 1 addition & 5 deletions .changes/window-controls-disable.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,4 @@
"tao": patch
---

Add APIs for disabling the individual window controls on desktop platforms:
`Window::set_closable`, `Window::is_closable`, `WindowBuilder::with_closable`,
`Window::set_minimizable`, `Window::is_minimizable`, `WindowBuilder::with_minimizable`,
`Window::set_maximizable`, `Window::is_maximizable`, `WindowBuilder::with_maximizable`.
See the docs for platform-specific notes, especially regarding Linux.
Add APIs for disabling the individual window controls on desktop platforms, `Window::set_closable`, `Window::is_closable`, `WindowBuilder::with_closable`, `Window::set_minimizable`, `Window::is_minimizable`, `WindowBuilder::with_minimizable`, `Window::set_maximizable`, `Window::is_maximizable`, `WindowBuilder::with_maximizable`. See the docs for platform-specific notes, especially regarding Linux.