-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: options to disable individual window controls, closes #116 #574
Conversation
It should be noted that disabling maximize was requested in each of the linked issues.
|
Yeah, they can be separate from each other.
Sure, whatever works for macOS. |
Agreed, that probably makes the most sense, especially since Tao seems to implement "zoom" as if it was maximize anyway. |
# Conflicts: # src/platform_impl/windows/window_state.rs
Note: I added an example for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks
This reverts commit ddb9f2b.
Co-authored-by: Amr Bashir <[email protected]>
Thanks for the review @amrbashir. All the changes made a lot of sense except #574 (comment) – please see my comment there. Is the change in behaviour intended? If so it will be different behaviour from other platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few nit-pick
Thanks @amrbashir, that seems to work. |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Platform support
Window::set_closable
Window::is_closable
WindowBuilder::with_closable
Window::set_minimizable
Window::is_minimizable
WindowBuilder::with_minimizable
Window::set_maximizable
Window::is_maximizable
WindowBuilder::with_maximizable
I am not able to find any GTK APIs which would make it possible to implement the
minimizable
andmaximizable
APIs on Linux.See #116 and tauri-apps/tauri#2353, tauri-apps/tauri#4286.