Fix for issue #209 #210
Merged
Fix for issue #209 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't work with |
Apply fixes from StyleCI
Apply fixes from StyleCI
carbontwelve
added a commit
that referenced
this pull request
Jul 7, 2017
* 🔧 setting version to 1.0.9-dev * 🐛 Fix for issue #209 (#210) * ✅ (TDD) amending test case for #209 * 🐛 fixed uri parsing * Apply fixes from StyleCI * 🐛 #! uri now supported * 📝 adding changelog for #209 * Apply fixes from StyleCI * ✨ double dot extension support added (#214) * ✅ TDD for #208 * ✨ Files with multiple ext no longer have their dots converted to dashes * 📝 adding changelog for #208 * 🚨 Apply fixes from StyleCI (#215) * ✨ implement --auto-publish flag (#216) * ✨ added --auto-publish flag * ✨ finished --auto-publish functionality * 📝 added changelog for #146 * 🚨 Apply fixes from StyleCI (#217) * 🔀 Solves issue #209 with bugfix (#220) * 📝 added changelog for #219 * 🐛 bugfix solves issue #129 * 🚨 Apply fixes from StyleCI (#221) * 🔀 Add permalink duplication warning for #156 (#222) * 📝 adding changelog for issue #156 * ✅ TDD for issue #156 * 🚚 unfinished adding of functionality * ✨ functionality for #156 complete * 🚨 Apply fixes from StyleCI (#223)
carbontwelve
added a commit
that referenced
this pull request
Jul 7, 2017
* 🔖 1.9.0 release (#224) * 🔧 setting version to 1.0.9-dev * 🐛 Fix for issue #209 (#210) * ✅ (TDD) amending test case for #209 * 🐛 fixed uri parsing * Apply fixes from StyleCI * 🐛 #! uri now supported * 📝 adding changelog for #209 * Apply fixes from StyleCI * ✨ double dot extension support added (#214) * ✅ TDD for #208 * ✨ Files with multiple ext no longer have their dots converted to dashes * 📝 adding changelog for #208 * 🚨 Apply fixes from StyleCI (#215) * ✨ implement --auto-publish flag (#216) * ✨ added --auto-publish flag * ✨ finished --auto-publish functionality * 📝 added changelog for #146 * 🚨 Apply fixes from StyleCI (#217) * 🔀 Solves issue #209 with bugfix (#220) * 📝 added changelog for #219 * 🐛 bugfix solves issue #129 * 🚨 Apply fixes from StyleCI (#221) * 🔀 Add permalink duplication warning for #156 (#222) * 📝 adding changelog for issue #156 * ✅ TDD for issue #156 * 🚚 unfinished adding of functionality * ✨ functionality for #156 complete * 🚨 Apply fixes from StyleCI (#223) * 🔧 updating version for 1.0.9
carbontwelve
added a commit
that referenced
this pull request
Jul 7, 2017
* 🔖 1.0.8 Release * 🎨 spelling * 🔧 amended composer build scripts * 📝 added some campaign details to links * 🔖 1.9.0 release (#225) * 🔖 1.9.0 release (#224) * 🔧 setting version to 1.0.9-dev * 🐛 Fix for issue #209 (#210) * ✅ (TDD) amending test case for #209 * 🐛 fixed uri parsing * Apply fixes from StyleCI * 🐛 #! uri now supported * 📝 adding changelog for #209 * Apply fixes from StyleCI * ✨ double dot extension support added (#214) * ✅ TDD for #208 * ✨ Files with multiple ext no longer have their dots converted to dashes * 📝 adding changelog for #208 * 🚨 Apply fixes from StyleCI (#215) * ✨ implement --auto-publish flag (#216) * ✨ added --auto-publish flag * ✨ finished --auto-publish functionality * 📝 added changelog for #146 * 🚨 Apply fixes from StyleCI (#217) * 🔀 Solves issue #209 with bugfix (#220) * 📝 added changelog for #219 * 🐛 bugfix solves issue #129 * 🚨 Apply fixes from StyleCI (#221) * 🔀 Add permalink duplication warning for #156 (#222) * 📝 adding changelog for issue #156 * ✅ TDD for issue #156 * 🚚 unfinished adding of functionality * ✨ functionality for #156 complete * 🚨 Apply fixes from StyleCI (#223) * 🔧 updating version for 1.0.9 * 🎨 Tidy up of todo's for #61 (#226) * 🔧 setting version to 1.0.9-dev * 🎨 tidy up old todo items for #61
Merged
carbontwelve
added a commit
that referenced
this pull request
Jul 7, 2017
* 🔖 1.0.8 Release * 🎨 spelling * 🔧 amended composer build scripts * 📝 added some campaign details to links * 🔖 1.9.0 release (#225) * 🔖 1.9.0 release (#224) * 🔧 setting version to 1.0.9-dev * 🐛 Fix for issue #209 (#210) * ✅ (TDD) amending test case for #209 * 🐛 fixed uri parsing * Apply fixes from StyleCI * 🐛 #! uri now supported * 📝 adding changelog for #209 * Apply fixes from StyleCI * ✨ double dot extension support added (#214) * ✅ TDD for #208 * ✨ Files with multiple ext no longer have their dots converted to dashes * 📝 adding changelog for #208 * 🚨 Apply fixes from StyleCI (#215) * ✨ implement --auto-publish flag (#216) * ✨ added --auto-publish flag * ✨ finished --auto-publish functionality * 📝 added changelog for #146 * 🚨 Apply fixes from StyleCI (#217) * 🔀 Solves issue #209 with bugfix (#220) * 📝 added changelog for #219 * 🐛 bugfix solves issue #129 * 🚨 Apply fixes from StyleCI (#221) * 🔀 Add permalink duplication warning for #156 (#222) * 📝 adding changelog for issue #156 * ✅ TDD for issue #156 * 🚚 unfinished adding of functionality * ✨ functionality for #156 complete * 🚨 Apply fixes from StyleCI (#223) * 🔧 updating version for 1.0.9 * 🎨 Tidy up of todo's for #61 (#226) * 🔧 setting version to 1.0.9-dev * 🎨 tidy up old todo items for #61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #209 by modifying the url helper's functionality to correctly parse uri strings and encode with
rawurlencodeorurlencodeas appropriate.