Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that two files of the same permalink don't conflict #156

Closed
carbontwelve opened this issue Apr 13, 2017 · 1 comment
Closed

Check that two files of the same permalink don't conflict #156

carbontwelve opened this issue Apr 13, 2017 · 1 comment
Labels
bug
Milestone
1.0.9

Comments

@carbontwelve
Copy link
Member

carbontwelve commented Apr 13, 2017 •
edited
Loading

If you have two files with the same permalink, Tapestry should highlight to the user the error and fail-back to one of two configured modes:

  1. Rename the file with an increment number e.g. filename-1.html while returning a "soft" error to the console to inform the user of what happened.
  2. Throw an error and output to console the issue before exiting with error code
@carbontwelve carbontwelve added this to the 1.0.8 milestone Apr 13, 2017
@carbontwelve carbontwelve modified the milestones: 1.0.8, 1.0.9 May 23, 2017
carbontwelve added a commit that referenced this issue Jul 4, 2017
@carbontwelve
📝 adding changelog for issue #156
4ccc4d2
carbontwelve added a commit that referenced this issue Jul 4, 2017
@carbontwelve
✅ TDD for issue #156
acd897a
carbontwelve added a commit that referenced this issue Jul 7, 2017
@carbontwelve
✨ functionality for #156 complete
7a3d084
@carbontwelve
Copy link
Member Author

This is fixed by #222

carbontwelve added a commit that referenced this issue Jul 7, 2017
@carbontwelve
🔀 Add permalink duplication warning for #156 (#222)
d3459c0 
* 📝 adding changelog for issue #156

* ✅ TDD for issue #156

* 🚚 unfinished adding of functionality

* ✨ functionality for #156 complete

* 🚨 Apply fixes from StyleCI (#223)
carbontwelve added a commit that referenced this issue Jul 7, 2017
@carbontwelve
🔖 1.9.0 release (#224)
552996e 
* 🔧 setting version to 1.0.9-dev

* 🐛 Fix for issue #209 (#210)

* ✅ (TDD) amending test case for #209

* 🐛 fixed uri parsing

* Apply fixes from StyleCI

* 🐛 #! uri now supported

* 📝 adding changelog for #209

* Apply fixes from StyleCI

* ✨ double dot extension support added (#214)

* ✅ TDD for #208

* ✨ Files with multiple ext no longer have their dots converted to dashes

* 📝 adding changelog for #208

* 🚨 Apply fixes from StyleCI (#215)

* ✨ implement --auto-publish flag (#216)

* ✨ added --auto-publish flag

* ✨ finished --auto-publish functionality

* 📝 added changelog for #146

* 🚨 Apply fixes from StyleCI (#217)

* 🔀 Solves issue #209 with bugfix (#220)

* 📝 added changelog for #219

* 🐛 bugfix solves issue #129

* 🚨 Apply fixes from StyleCI (#221)

* 🔀 Add permalink duplication warning for #156 (#222)

* 📝 adding changelog for issue #156

* ✅ TDD for issue #156

* 🚚 unfinished adding of functionality

* ✨ functionality for #156 complete

* 🚨 Apply fixes from StyleCI (#223)
carbontwelve added a commit that referenced this issue Jul 7, 2017
@carbontwelve
🔖 1.9.0 release (#225)
12611d1 
* 🔖 1.9.0 release (#224)

* 🔧 setting version to 1.0.9-dev

* 🐛 Fix for issue #209 (#210)

* ✅ (TDD) amending test case for #209

* 🐛 fixed uri parsing

* Apply fixes from StyleCI

* 🐛 #! uri now supported

* 📝 adding changelog for #209

* Apply fixes from StyleCI

* ✨ double dot extension support added (#214)

* ✅ TDD for #208

* ✨ Files with multiple ext no longer have their dots converted to dashes

* 📝 adding changelog for #208

* 🚨 Apply fixes from StyleCI (#215)

* ✨ implement --auto-publish flag (#216)

* ✨ added --auto-publish flag

* ✨ finished --auto-publish functionality

* 📝 added changelog for #146

* 🚨 Apply fixes from StyleCI (#217)

* 🔀 Solves issue #209 with bugfix (#220)

* 📝 added changelog for #219

* 🐛 bugfix solves issue #129

* 🚨 Apply fixes from StyleCI (#221)

* 🔀 Add permalink duplication warning for #156 (#222)

* 📝 adding changelog for issue #156

* ✅ TDD for issue #156

* 🚚 unfinished adding of functionality

* ✨ functionality for #156 complete

* 🚨 Apply fixes from StyleCI (#223)

* 🔧 updating version for 1.0.9
carbontwelve added a commit that referenced this issue Jul 7, 2017
@carbontwelve
🔀 Pull Master into lost 1.0.9 commits (#227)
343be8e 
* 🔖 1.0.8 Release

* 🎨 spelling

* 🔧 amended composer build scripts

* 📝 added some campaign details to links

* 🔖 1.9.0 release (#225)

* 🔖 1.9.0 release (#224)

* 🔧 setting version to 1.0.9-dev

* 🐛 Fix for issue #209 (#210)

* ✅ (TDD) amending test case for #209

* 🐛 fixed uri parsing

* Apply fixes from StyleCI

* 🐛 #! uri now supported

* 📝 adding changelog for #209

* Apply fixes from StyleCI

* ✨ double dot extension support added (#214)

* ✅ TDD for #208

* ✨ Files with multiple ext no longer have their dots converted to dashes

* 📝 adding changelog for #208

* 🚨 Apply fixes from StyleCI (#215)

* ✨ implement --auto-publish flag (#216)

* ✨ added --auto-publish flag

* ✨ finished --auto-publish functionality

* 📝 added changelog for #146

* 🚨 Apply fixes from StyleCI (#217)

* 🔀 Solves issue #209 with bugfix (#220)

* 📝 added changelog for #219

* 🐛 bugfix solves issue #129

* 🚨 Apply fixes from StyleCI (#221)

* 🔀 Add permalink duplication warning for #156 (#222)

* 📝 adding changelog for issue #156

* ✅ TDD for issue #156

* 🚚 unfinished adding of functionality

* ✨ functionality for #156 complete

* 🚨 Apply fixes from StyleCI (#223)

* 🔧 updating version for 1.0.9

* 🎨 Tidy up of todo's for #61 (#226)

* 🔧 setting version to 1.0.9-dev

* 🎨 tidy up old todo items for #61
@carbontwelve carbontwelve mentioned this issue Jul 7, 2017
Merged
carbontwelve added a commit that referenced this issue Jul 7, 2017
@carbontwelve
🔀 Pull Master into lost 1.0.9 commits (#227) (#228)
f28b76e 
* 🔖 1.0.8 Release

* 🎨 spelling

* 🔧 amended composer build scripts

* 📝 added some campaign details to links

* 🔖 1.9.0 release (#225)

* 🔖 1.9.0 release (#224)

* 🔧 setting version to 1.0.9-dev

* 🐛 Fix for issue #209 (#210)

* ✅ (TDD) amending test case for #209

* 🐛 fixed uri parsing

* Apply fixes from StyleCI

* 🐛 #! uri now supported

* 📝 adding changelog for #209

* Apply fixes from StyleCI

* ✨ double dot extension support added (#214)

* ✅ TDD for #208

* ✨ Files with multiple ext no longer have their dots converted to dashes

* 📝 adding changelog for #208

* 🚨 Apply fixes from StyleCI (#215)

* ✨ implement --auto-publish flag (#216)

* ✨ added --auto-publish flag

* ✨ finished --auto-publish functionality

* 📝 added changelog for #146

* 🚨 Apply fixes from StyleCI (#217)

* 🔀 Solves issue #209 with bugfix (#220)

* 📝 added changelog for #219

* 🐛 bugfix solves issue #129

* 🚨 Apply fixes from StyleCI (#221)

* 🔀 Add permalink duplication warning for #156 (#222)

* 📝 adding changelog for issue #156

* ✅ TDD for issue #156

* 🚚 unfinished adding of functionality

* ✨ functionality for #156 complete

* 🚨 Apply fixes from StyleCI (#223)

* 🔧 updating version for 1.0.9

* 🎨 Tidy up of todo's for #61 (#226)

* 🔧 setting version to 1.0.9-dev

* 🎨 tidy up old todo items for #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.9
Development

No branches or pull requests
1 participant
@carbontwelve